Skip to content

dynamic_layouts wrap test is flaky #132321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Piinks opened this issue Aug 10, 2023 · 1 comment · Fixed by flutter/packages#4681
Closed

dynamic_layouts wrap test is flaky #132321

Piinks opened this issue Aug 10, 2023 · 1 comment · Fixed by flutter/packages#4681
Assignees
@Piinks
Labels
a: tests "flutter test", flutter_test, or one of our tests c: flake Tests that sometimes, but not always, incorrectly pass p: dynamic_layouts The dynamic_layouts package package flutter/packages repository. See also p: labels.

Comments

@Piinks
Copy link
Contributor

Piinks commented Aug 10, 2023 •
edited
Loading

This test has broken at least twice recently, courtesy of an engine roll making small text rendering changes. We should refactor the test to make it more robust to rolls.
@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests package flutter/packages repository. See also p: labels. c: flake Tests that sometimes, but not always, incorrectly pass p: dynamic_layouts The dynamic_layouts package labels Aug 10, 2023
@Piinks Piinks self-assigned this Aug 10, 2023
This was referenced Aug 10, 2023
Merged
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Aug 11, 2023
@Piinks
[dynamic_layouts] Refactor flaky test (#4681)
ea49db5 
This refactors a test for the example of a wrapped layout in dynamic_tests. This test had become brittle to small text changes because it would check the precise layout offset of the text.

It was patched in these cases in #4513 and #4677 to address tiny text variations across platforms and material 2/3 defaults. This refactor changes the test to check the layout offset of the parent Container of the text, which should not have these subtle variations.

Fixes flutter/flutter#132321
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Piinks Piinks

Labels
a: tests "flutter test", flutter_test, or one of our tests c: flake Tests that sometimes, but not always, incorrectly pass p: dynamic_layouts The dynamic_layouts package package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dynamic_layouts] Refactor flaky test Piinks/packages
1 participant
@Piinks