Skip to content

[Android] MaybeWaitOnFence doesn't signal with videos/Impeller. #143720

Closed
flutter/engine
#50792
@jonahwilliams

Description

@jonahwilliams

Running the Flutter Gallery app with Impeller/Vulkan and the YUV sampler patch from @chinmaygarde

flutter_01

Logs are full of

E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.
E/ImageReaderSurfaceProducer( 3117): acquireLatestImage image's fence was never signalled.

CPU profile looks like:

Despite never signalling, we spend 50 ms out of 180ms CPU time checking it. Is this working in other cases, because it seems like its extraordinarily expensive for something that isn't working at all.

image

See also: #142153

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: performanceRelates to speed or footprint issues (see "perf:" labels)e: impellerImpeller rendering backend issues and features requestsengineflutter/engine repository. See also e: labels.platform-androidAndroid applications specificallyr: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions