Skip to content

Add privacy manifest to 1p macOS plugins #155564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmagman opened this issue Sep 23, 2024 · 2 comments · Fixed by flutter/packages#7687
Closed

Add privacy manifest to 1p macOS plugins #155564

jmagman opened this issue Sep 23, 2024 · 2 comments · Fixed by flutter/packages#7687
Assignees
Labels
a: plugins Support for writing, building, and running plugin packages fyi-ecosystem For the attention of Ecosystem team P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-macos Owned by the macOS platform team

Comments

@jmagman
Copy link
Member

jmagman commented Sep 23, 2024

According to #154915, Apple will start requiring privacy manifests for macOS on November 12, 2024:

ITMS-91061: Missing privacy manifest - Your app includes “Contents/Frameworks/FlutterMacOS.framework/Versions/A/FlutterMacOS”, which includes Flutter, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

flutter/packages repo should add privacy manifest similar to #131495. NSPrivacyTracking* and NSPrivacyCollectedDataTypes keys are required, but the values can be blank. macOS explicitly does not need the NSPrivacyAccessedAPITypes (see more info in #143381)

See the iOS PR flutter/packages#5846 for what work needs to be done for this.

@jmagman jmagman added P1 High-priority issues at the top of the work list a: plugins Support for writing, building, and running plugin packages fyi-ecosystem For the attention of Ecosystem team team-macos Owned by the macOS platform team package flutter/packages repository. See also p: labels. labels Sep 23, 2024
@stuartmorgan-g
Copy link
Contributor

Looks like file_selector_macos and url_launcher_macos are the only ones without them (since most are shared implementation packages, so macOS got it for free when we did iOS).

Neither of them are listed on the SDK page, but url_launcher is, so it may be that url_launcher_macos is silently included the same way that FlutterMacOS isn't listed but apparently counts as Flutter. Although the page does list url_launcher_ios, so 🤷🏻 .

Easy enough to just add it to both of them and update the tooling to enforce it. I'll do that shortly.

@stuartmorgan-g stuartmorgan-g self-assigned this Sep 23, 2024
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue Sep 23, 2024
macOS privacy manifest enforcement is rolling out soon, so this brings
all macOS plugins into alignment with our iOS policy of always having a
manifest, including updating the repo tooling to enforce that.

Very few plugins are affected because most share the implementation
package with iOS, and we didn't do any target platform switching when
adding the manifests for iOS, automatically covering macOS as well.

Fixes flutter/flutter#155564
Copy link

github-actions bot commented Oct 8, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: plugins Support for writing, building, and running plugin packages fyi-ecosystem For the attention of Ecosystem team P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-macos Owned by the macOS platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants