Skip to content

[web] make engine/framework dev cycle more pleasant #40392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yjbanov opened this issue Sep 12, 2019 · 1 comment · Fixed by flutter/engine#12303
Closed

[web] make engine/framework dev cycle more pleasant #40392

yjbanov opened this issue Sep 12, 2019 · 1 comment · Fixed by flutter/engine#12303
Assignees
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine repository. See also e: labels.

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Sep 12, 2019

In order for us to quickly iterate on Flutter for web, we need to be able to quickly debug changes we make both in the web engine and in the framework. Currently, this requires a non-trivial manual sequence of commands involving gn, ninja, and flutter_tools, executed at the right moment.

Let's build a contributor-only dev tool that encapsulates this complexity.

/cc @mdebbar this is about your upcoming felt build --watch tool. I'm filing it so we can track progress as part of the "Flutter for web infrastructure 2019" project. Feel free to adjust the labels as you see fit.

/cc @jonahwilliams this builds on the work you've already done in the flutter tool, but we may need your help if we encounter issues.

@yjbanov yjbanov added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine repository. See also e: labels. labels Sep 12, 2019
@yjbanov yjbanov added this to the September 2019 milestone Sep 12, 2019
mdebbar added a commit to mdebbar/engine that referenced this issue Sep 13, 2019
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes flutter/flutter#40392
mdebbar added a commit to mdebbar/engine that referenced this issue Sep 13, 2019
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes flutter/flutter#40392
mdebbar added a commit to mdebbar/engine that referenced this issue Sep 13, 2019
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes flutter/flutter#40392
mdebbar added a commit to mdebbar/engine that referenced this issue Sep 16, 2019
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes flutter/flutter#40392
mdebbar added a commit to mdebbar/engine that referenced this issue Sep 17, 2019
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes flutter/flutter#40392
mdebbar added a commit to flutter/engine that referenced this issue Sep 17, 2019
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes flutter/flutter#40392
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants