Skip to content

flutter_desktop_darwin_unittests fails in AOT modes (profile and release) #66664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gspencergoog opened this issue Sep 25, 2020 · 1 comment · Fixed by flutter/engine#21670
Closed

flutter_desktop_darwin_unittests fails in AOT modes (profile and release) #66664

gspencergoog opened this issue Sep 25, 2020 · 1 comment · Fixed by flutter/engine#21670
Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-mac Building on or for macOS specifically

Comments

@gspencergoog
Copy link
Contributor

gspencergoog commented Sep 25, 2020 •
edited
Loading

When AOT fixtures are built in release/profile mode, flutter_desktop_darwin_unittests crashes with the following error:

[ERROR:flutter/runtime/dart_vm_data.cc(18)] VM snapshot invalid and could not be inferred from settings.
[ERROR:flutter/runtime/dart_vm.cc(249)] Could not setup VM data to bootstrap the VM from.
[ERROR:flutter/runtime/dart_vm_lifecycle.cc(84)] Could not create Dart VM instance.
[FATAL:flutter/shell/common/shell.cc(265)] Check failed: vm. Must be able to initialize the VM.
[ERROR:flutter/fml/backtrace.cc(110)] Caught signal SIGABRT during program execution.

We need to move the the FlutterDartProject initialization to conditionally check if the engine is in AOT mode. The fixture should generate the AOT assets already.

See flutter/engine#20531 (comment) and flutter/engine#21231 (comment)

cc @chinmaygarde @stuartmorgan
@gspencergoog gspencergoog added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. labels Sep 25, 2020
@gspencergoog gspencergoog mentioned this issue Sep 25, 2020
Merged
1 task
@stuartmorgan-g stuartmorgan-g added a: desktop Running on desktop P1 High-priority issues at the top of the work list platform-mac Building on or for macOS specifically labels Sep 28, 2020
iskakaushik added a commit to iskakaushik/engine that referenced this issue Oct 7, 2020
@iskakaushik
Run desktop darwin tests in debug mode
e1cac01 
See: flutter/flutter#66664
@iskakaushik iskakaushik mentioned this issue Oct 7, 2020
Merged
iskakaushik added a commit to iskakaushik/engine that referenced this issue Oct 7, 2020
@iskakaushik
Run desktop darwin tests in debug mode
6b64b7d 
See: flutter/flutter#66664
@chinmaygarde chinmaygarde mentioned this issue Oct 7, 2020
Merged
iskakaushik added a commit to iskakaushik/engine that referenced this issue Oct 7, 2020
@iskakaushik
[macOS] flutter_desktop_darwin_unittests can be enabled for all runti…
64e9a08 
…me modes

Given that flutter/flutter#66664 has been fixed
@iskakaushik iskakaushik mentioned this issue Oct 7, 2020
Merged
iskakaushik added a commit to iskakaushik/engine that referenced this issue Oct 8, 2020
@iskakaushik
[macOS] flutter_desktop_darwin_unittests can be enabled for all runti…
d364c17 
…me modes

Given that flutter/flutter#66664 has been fixed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-mac Building on or for macOS specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[macOS] Allow loading of AOT snapshots and instructions from elf bundle iskakaushik/engine
3 participants
@stuartmorgan-g @gspencergoog @pedromassangocode