Skip to content

with_coverage_time_ms, without_change_elapsed_time_ms flutter_test_performance regressions. #71851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kf6gpe opened this issue Dec 7, 2020 · 11 comments
Closed

with_coverage_time_ms, without_change_elapsed_time_ms flutter_test_performance regressions. #71851

kf6gpe opened this issue Dec 7, 2020 · 11 comments
Assignees
@gw280
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks
Milestone
January Beta Rele...

Comments

@kf6gpe
Copy link
Contributor

kf6gpe commented Dec 7, 2020

https://flutter-flutter-perf.skia.org/e/?begin=1607101951&end=1607126887&keys=Xcdf4b4870fdb6d16ea08ac351176954f&num_commits=50&request_type=1&xbaroffset=22738

Same roll as #71850; #71699.
@kf6gpe kf6gpe added c: regression It was better in the past than it is now engine flutter/engine repository. See also e: labels. c: performance Relates to speed or footprint issues (see "perf:" labels) perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks P0 Critical issues such as a build break or regression labels Dec 7, 2020
@chinmaygarde
Copy link
Member

chinmaygarde commented Dec 7, 2020 •
edited
Loading

cc @cbracken. I believe we need to bisect this to a Dart SDK roll. Unfortunately, there are 7 Dart SDK rolls in the engine roll.

@chinmaygarde chinmaygarde added this to the 1.26 - December 2020 milestone Dec 7, 2020
@Hixie Hixie assigned gw280 and unassigned cbracken Dec 9, 2020
@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2020

Reassigned per @cbracken.

@zanderso
Copy link
Member

@gw280 I believe you mentioned you were working on the bisect. Please give a shout if you are blocked on anything.

@gw280
Copy link
Contributor

gw280 commented Dec 10, 2020

Bisect is still ongoing. I keep hitting roadblocks, the latest one being getting a working android environment setup on my P920 which (I believe) is the reason the test isn't running locally.

@gw280
Copy link
Contributor

gw280 commented Dec 10, 2020

It's this Dart SDK roll: flutter/engine#22801

@zanderso zanderso added the dependency: dart Dart team may need to help us label Dec 10, 2020
@zanderso
Copy link
Member

zanderso commented Dec 10, 2020 •
edited
Loading

@jensjoha several PRs this area in that roll:

https://dart.googlesource.com/sdk.git/+log/7a2a3968ef53..e9a03fd98faa

@gw280
Copy link
Contributor

gw280 commented Dec 10, 2020

I just bisected that roll, it's due to this change: https://dart.googlesource.com/sdk.git/+/27ed7912af86426288107bfaa09b31c36099e4ba

@jensjoha
Copy link
Contributor

Should be fixed with https://dart-review.googlesource.com/c/sdk/+/175724.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Dec 11, 2020
@jensjoha
[kernel] Fix and test readComponentSource
739393b 
This was broken after constant coverage was recorded in dill because
reading the source then needed to have the link table too (which it
doesn't have when using readComponentSource).

Fixes flutter/flutter#71851.

Change-Id: I90b6a185abd133c7d08fd335f69faf634684738b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175724
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
@chinmaygarde
Copy link
Member

The linked fix landed 3 days ago but the autoroller was paused for #72158. I have re-enabled it now and it should be rolled in soon-ish.

@gw280
Copy link
Contributor

gw280 commented Dec 15, 2020

https://flutter-flutter-perf.skia.org/e/?begin=1606867006&queries=sub_result%3Dwithout_change_elapsed_time_ms&requestType=0 - looks like we're back down to the old figures again. Closing.

@gw280 gw280 closed this as completed Dec 15, 2020
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gw280 gw280

Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression perf: speed Performance issues related to (mostly rendering) speed team: benchmark Performance issues found by inspecting benchmarks
Projects
None yet
Milestone
January Beta Release (1.26)
Development

No branches or pull requests
8 participants
@chinmaygarde @cbracken @Hixie @gw280 @kf6gpe @zanderso @jensjoha @pedromassangocode