Skip to content

Update expat #91384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Oct 6, 2021 · 5 comments · Fixed by flutter/engine#29813
Closed

Update expat #91384

Hixie opened this issue Oct 6, 2021 · 5 comments · Fixed by flutter/engine#29813
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list

Comments

@Hixie
Copy link
Contributor

Hixie commented Oct 6, 2021

It appears we have literally never updated expat in the history of our project: https://flutter.googlesource.com/third_party/expat/+/refs/heads/master/files/Changes

We really should update expat if we're going to use it.

cc @zanderso

@Hixie Hixie added engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list labels Oct 6, 2021
@zanderso
Copy link
Member

zanderso commented Oct 6, 2021

It looks like this is only used by Skia? Can we just mimic what Skia does instead of putting this under flutter.googlesource.com? https://github.com/google/skia/blame/main/DEPS#L26. Looks like Skia has it's own BUILD.gn file anyway, so maybe this is just pulling the bits from a different place. @cbracken @jason-simmons for advice.

@elson-dsouza
Copy link

Hello do we have an update on this. Our security scans keep flagging this lib due to vulnerabilities in the version of expat being used here

@Hixie
Copy link
Contributor Author

Hixie commented Nov 18, 2021

@elson-dsouza the good news is it's only used for parsing the font file on Android so there's not actually a vulnerability here, which is why we haven't been jumping on this as fast as we would otherwise. But let me see if I can raise the priority.

jason-simmons added a commit to jason-simmons/flutter_buildroot that referenced this issue Nov 18, 2021
jason-simmons added a commit to flutter/buildroot that referenced this issue Nov 18, 2021
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Nov 18, 2021
Hixie pushed a commit to Hixie/sky_engine that referenced this issue Nov 19, 2021
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Nov 19, 2021
Update license script for new expat

Fixes flutter/flutter#91384
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Nov 19, 2021
Update license script for new expat

Fixes flutter/flutter#91384
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Nov 19, 2021
Update license script for new expat

Fixes flutter/flutter#91384
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Nov 19, 2021
Update license script for new expat

Fixes flutter/flutter#91384
jason-simmons added a commit to flutter/engine that referenced this issue Nov 19, 2021
Update license script for new expat

Fixes flutter/flutter#91384
@zanderso
Copy link
Member

Thanks, @jason-simmons !

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants