Skip to content

Hide default bundle id error when xcresult detects an error #101993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Apr 15, 2022

This PR make sure the default bundle id error only shows when xcresult doesn't detect errors.

Fixes #100723

sample output:

Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **


Xcode's output:
↳
    Writing result bundle at path:
        /var/folders/8b/jd2fgk_51k3bv218hf4v5cd800l9tg/T/flutter_tools.tIgW0p/flutter_ios_build_temp_dirUl1liT/tem
        porary_xcresult_bundle

    /Users/ychris/tmp/keyboard_inset_tests/ios/Runner/AppDelegate.swift:8:83: error: cannot find type 'Any1' in
    scope
        didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any1]?
                                                                                      ^~~~
    /Users/ychris/tmp/keyboard_inset_tests/ios/Runner/AppDelegate.swift:6:17: error: method does not override
    any method from its superclass
      override func application(
      ~~~~~~~~      ^
    note: Using new build system
    note: Planning
    note: Build preparation complete
    note: Building targets in parallel

    Result bundle written to path:
        /var/folders/8b/jd2fgk_51k3bv218hf4v5cd800l9tg/T/flutter_tools.tIgW0p/flutter_ios_build_temp_dirUl1liT/tem
        porary_xcresult_bundle


Could not build the precompiled application for the device.
Swift Compiler Error (Xcode): Cannot find type 'Any1' in scope
/Users/ychris/tmp/keyboard_inset_tests/ios/Runner/AppDelegate.swift:7:82


Swift Compiler Error (Xcode): Method does not override any method from its superclass
/Users/ychris/tmp/keyboard_inset_tests/ios/Runner/AppDelegate.swift:5:16



Error launching application on iPhone.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 15, 2022
@cyanglaz cyanglaz requested a review from jmagman April 15, 2022 17:28
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

if (!issueDetected && _needUpdateSigningIdentifier(xcodeBuildExecution)) {
issueDetected = true;
logger.printError('');
logger.printError('It appears that your application still contains the default signing identifier.');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use logger.printBox for consistency with Android

@cyanglaz cyanglaz deleted the default_bundle_id branch April 15, 2022 23:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode build failures are not printed when codesigning is off
4 participants