Skip to content

Fix spacing issues in typography.dart, navigation_bar.dart and modal_barrier.dart #102136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix spacing issues in typography.dart, navigation_bar.dart and modal_barrier.dart #102136

merged 1 commit into from
Apr 20, 2022

Conversation

TahaTesser
Copy link
Member

fixes #102134

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 19, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@TahaTesser TahaTesser requested a review from rami-a April 19, 2022 10:26
@TahaTesser
Copy link
Member Author

cc: @Hixie
This needs a test exemption

@TahaTesser TahaTesser requested review from guidezpl and removed request for rami-a April 19, 2022 10:28
HansMuller
HansMuller approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@HansMuller HansMuller merged commit e526f85 into flutter:master Apr 20, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 20, 2022
@engine-flutter-autoroll
e526f85 Fix spacings in typography.dart, navigation_bar.dart and …
8eabdc2 
…`modal_barrier.dart` (flutter/flutter#102136)
@Hixie
Copy link
Contributor

Hixie commented Apr 20, 2022

test-exempt: code refactor with no semantic change

Hixie
Hixie reviewed Apr 20, 2022
View reviewed changes
packages/flutter/lib/src/material/typography.dart
bodySmall: TextStyle(debugLabel: 'blackMountainView bodySmall', fontFamily: 'Roboto', color: Colors.black54, decoration: TextDecoration.none),
labelLarge: TextStyle(debugLabel: 'blackMountainView labelLarge', fontFamily: 'Roboto', color: Colors.black87, decoration: TextDecoration.none),
labelMedium: TextStyle(debugLabel: 'blackMountainView labelMedium', fontFamily: 'Roboto', color: Colors.black, decoration: TextDecoration.none),
labelSmall: TextStyle(debugLabel: 'blackMountainView labelSmall', fontFamily: 'Roboto', color: Colors.black, decoration: TextDecoration.none),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw this file used to be vertically aligned so that we could easily see the differences on each line, which might be even better than this. not a big deal though. (it probably changed when we changed the names, hence the weird inconsistent spaces you fixed)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense now, I did notice M3 tokens didn't have spacings so I wanted to fix the whole class in this PR

@TahaTesser TahaTesser deleted the fix_spacings branch April 21, 2022 18:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
e526f85 Fix spacings in typography.dart, navigation_bar.dart and …
351398d 
…`modal_barrier.dart` (flutter/flutter#102136)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@TahaTesser @egramond
Fix spacings in typography.dart, navigation_bar.dart and `modal_b…
38f437b 
…arrier.dart` (flutter#102136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie left review comments

@HansMuller HansMuller HansMuller approved these changes

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix spacing issues in some classes
4 participants
@TahaTesser @Hixie @HansMuller @guidezpl