Skip to content

Revert "Benchmark cannot run in Android12 phone" #102649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 27, 2022
@zanderso zanderso requested a review from dnfield April 27, 2022 14:07
@zanderso
Copy link
Member Author

@JsouLiang

@dnfield
Copy link
Contributor

dnfield commented Apr 27, 2022

Is the tool injecting this automatically?

@JsouLiang
Copy link
Contributor

@zanderso hello, My pr had passed all CI checks, why in here is very red?

@zanderso zanderso merged commit 9876b0d into master Apr 27, 2022
@zanderso zanderso deleted the revert-100761-benchmark-cannot-run-in-android-12 branch April 27, 2022 14:27
@zanderso
Copy link
Member Author

@keyonghan The bot should have landed this clean tip-of-tree revert. Instead, it had to wait for a review, and even then the bot still didn't land it.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
@keyonghan
Copy link
Contributor

@keyonghan The bot should have landed this clean tip-of-tree revert. Instead, it had to wait for a review, and even then the bot still didn't land it.

Tracking issue: #100232. Will take a look.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2022
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants