fix SliverReorderableList not work on Android platform bug
#103406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
|
This should release with #97971 CC @jonahwilliams |
| @@ -7,6 +7,65 @@ import 'package:flutter/material.dart'; | |||
| import 'package:flutter_test/flutter_test.dart'; | |||
|
|
|||
| void main() { | |||
| testWidgets('SliverReorderableList works well when having gestureSettings', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
How does this catch the regression? The tester will have the same default touch slop value since it is not run on android - you'd need to override the platform config on the test window to provide a touch slop value that is different than the default value.
There was a problem hiding this comment.
I have overridden the MediaQueryData of the pump widget.
| @@ -7,6 +7,65 @@ import 'package:flutter/material.dart'; | |||
| import 'package:flutter_test/flutter_test.dart'; | |||
|
|
|||
| void main() { | |||
| testWidgets('SliverReorderableList works well when having gestureSettings', (WidgetTester tester) async { | |||
| // Regression test for https://github.com/flutter/flutter/issues/103404 | |||
| debugPrintGestureArenaDiagnostics = true; | |||
There was a problem hiding this comment.
nit: please remove these for tests or ensure they are wrapped in a try / finally so a testfailure doesn't fail everything in this file
|
Thanks @xu-baolin ! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 12, 2022
jonahwilliams
pushed a commit
to jonahwilliams/flutter
that referenced
this pull request
Jun 1, 2022
itsjustkevin
pushed a commit
that referenced
this pull request
Jun 1, 2022
…egressions (#105141) * [framework] fix slider regression due to touch slop changes (#103569) * fix `SliverReorderableList` not work on Android platform bug (#103406) Co-authored-by: xubaolin <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103404
Was introduced by #97971