-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Expose the duration and curve for theme animation in MaterialApp. #107383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the duration and curve for theme animation in MaterialApp. #107383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What happens if these parameters are changed while a theme animation is underway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the underlying flutter/packages/flutter/lib/src/widgets/implicit_animations.dart Lines 382 to 389 in f980d66
Do you think we need to call this out in the docs for MaterialApp? |
#107383 (comment) sounds OK, I don't think we need to document that case. |
When a
MaterialApp
's theme changes, it is animated over time (via theAnimatedTheme
widget). This PR exposes the duration and curve used for this animation:Or if you want to turn off the animation altogether, you can set the duration to zero:
Fixed: #105883
Pre-launch Checklist
///
).