-
Notifications
You must be signed in to change notification settings - Fork 28.5k
remove unused members in executable libs #107464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! This looks like a nice cleanup!
dev/bots/unpublish_package.dart
Outdated
@@ -10,11 +10,9 @@ | |||
/// If asked to remove a release that is currently the release on that channel, | |||
/// it will replace that release with the next most recent release on that | |||
/// channel. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: keep this blank line.
Try again when the tree status has been applied to this PR. |
@a14n Does this PR clean up unused members across the entire flutter/flutter repository and we only had them in the |
I ran the lint rule on the entire flutter/flutter repo. There are only 2 reports that I didn't touch. Not really false-positive but strange code that I don't really understand:
|
Thanks. Those two look like they are on purpose (I wish we would have added a comment to explain that when we first introduced them). I am a little surprised it didn't find any of the stuff I found in #104561 with a different tool. Do you have any idea why those didn't show up? |
|
After a quick random check it looks like all those lib are not executable libraries (containing a |
That makes sense. Thanks for checking! |
Related to dart-lang/sdk#57580 and dart-lang/sdk#58292