Skip to content

[CP] Fix a type casting error in text_input.dart #114806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2022
Merged

[CP] Fix a type casting error in text_input.dart #114806

merged 3 commits into from
Nov 9, 2022

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Nov 7, 2022

(cherry picked from commit 8caa14e)
The numbers can be integers.

Fixes #109632

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Nov 7, 2022
@AlexV525 AlexV525 mentioned this pull request Nov 7, 2022
Closed
@CaseyHillers CaseyHillers self-requested a review November 7, 2022 17:54
@CaseyHillers CaseyHillers merged commit 52b3dc2 into flutter:flutter-3.2-candidate.5 Nov 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 9, 2022
@engine-flutter-autoroll
52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (f…
f2c530e 
…lutter/flutter#114806)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2022
@engine-flutter-autoroll
52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (f…
1b082bc 
…lutter/flutter#114806)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 9, 2022
@engine-flutter-autoroll
Roll Flutter (stable) from e99c9c7cd9f6 to 52b3dc25f647 (4 revisions) (…
a2b4583 
…#2792)

* 7fb1d47b6 [releases] Handle privatecommand messages that pass no data #112590 (flutter/flutter#114461)

* 013ada8cf [release] Do not assume that pub is the first command run by "flutter create" (#114621) (flutter/flutter#114945)

* a1b297691 CP: Fix the path where footer is written. (flutter/flutter#114947)

* 52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (flutter/flutter#114806)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (f…
d30fe75 
…lutter/flutter#114806)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll
Roll Flutter (stable) from e99c9c7cd9f6 to 52b3dc25f647 (4 revisions) (…
11cb483 
…#6690)

* 7fb1d47b6 [releases] Handle privatecommand messages that pass no data #112590 (flutter/flutter#114461)

* 013ada8cf [release] Do not assume that pub is the first command run by "flutter create" (#114621) (flutter/flutter#114945)

* a1b297691 CP: Fix the path where footer is written. (flutter/flutter#114947)

* 52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (flutter/flutter#114806)
@AlexV525 AlexV525 deleted the cp-8caa14e branch November 16, 2022 08:23
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter (stable) from e99c9c7cd9f6 to 52b3dc25f647 (4 revisions) (…
e2eab61 
…flutter#2792)

* 7fb1d47b6 [releases] Handle privatecommand messages that pass no data #112590 (flutter/flutter#114461)

* 013ada8cf [release] Do not assume that pub is the first command run by "flutter create" (#114621) (flutter/flutter#114945)

* a1b297691 CP: Fix the path where footer is written. (flutter/flutter#114947)

* 52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (flutter/flutter#114806)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter (stable) from e99c9c7cd9f6 to 52b3dc25f647 (4 revisions) (…
c17b0db 
…flutter#6690)

* 7fb1d47b6 [releases] Handle privatecommand messages that pass no data #112590 (flutter/flutter#114461)

* 013ada8cf [release] Do not assume that pub is the first command run by "flutter create" (#114621) (flutter/flutter#114945)

* a1b297691 CP: Fix the path where footer is written. (flutter/flutter#114947)

* 52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (flutter/flutter#114806)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter (stable) from e99c9c7cd9f6 to 52b3dc25f647 (4 revisions) (…
cfa1eb7 
…flutter#6690)

* 7fb1d47b6 [releases] Handle privatecommand messages that pass no data #112590 (flutter/flutter#114461)

* 013ada8cf [release] Do not assume that pub is the first command run by "flutter create" (#114621) (flutter/flutter#114945)

* a1b297691 CP: Fix the path where footer is written. (flutter/flutter#114947)

* 52b3dc25f [CP] Fix a type casting error in text_input.dart (#109635) (flutter/flutter#114806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexV525 @CaseyHillers @LongCatIsLooong