-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Fix ExpansionTile
double tap to collapse/expanded and expanded/collapsed states semantics announcements
#120881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ExpansionTile
double tap to collapse/expanded and expanded/collapsed states semantics announcements
#120881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked with google internal a11y guideline and looks like this is also required for Android
1.4
Consider providing accessibility hints, especially in cases where additional detail may be helpful in explaining a click or long-click action. This is accomplished by overriding a standard accessibility action with a custom label, which will be appended to TalkBack’s feedback after the View’s content is spoken.
For example, if clicking on a card expands its contents to show more detail, but this isn’t conveyed in TalkBack’s output because the card contains other text, applying an accessibility hint as follows would result in TalkBack appending “Double tap to expand for more details.”, which provides a more polished user experience.
For iOS, we should add a SemanticsProperties.hint. The onTapHint does not work on iOS.
https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/iPhoneAccessibility/Making_Application_Accessible/Making_Application_Accessible.html#//apple_ref/doc/uid/TP40008785-CH102-SW6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f473f10
to
ea9d305
Compare
@chunhtai (updated demo video) |
ea9d305
to
cd89be2
Compare
cd89be2
to
ae5ec92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit fd65fd1.
This reverts commit fd65fd1.
…er#121624) This reverts commit fd65fd1.
fixes #120650
code sample
Demo
telegram-cloud-document-5-6334536656577628266.mp4
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.