Skip to content

Fix formatting in TabController #121167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix formatting in TabController #121167

merged 1 commit into from
Feb 21, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 21, 2023

Came across some scary formatting today. Fixing per the style guide.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 21, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Feb 21, 2023

test-exempt: code refactor with no semantic change

Hixie
Hixie reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot merged commit c6e1a4d into flutter:master Feb 21, 2023
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
c6e1a4dc9 Fix formatting (flutter/flutter#121167)
d59f4d0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
06d8186
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
24e7194
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
8059f42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
e9d3d17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
562b132
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
1bd7ffb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
e53ac0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
e35f306
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
889786d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
a0d8f4b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
1b456b2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
8604454
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
b626a93
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
073ba15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
8b199ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
cec0245
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
d51c32c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
4877559
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
7422ff3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
d772c19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
8517a7e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
3b9aca3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
822bcfa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
c9f5b82
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
a0d7abf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c6e1a4d Fix formatting (flutter/flutter#121167)
ee297b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piinks @Hixie