Skip to content

Remove outdated TODO #121200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2023
Merged

Remove outdated TODO #121200

merged 3 commits into from
Feb 23, 2023

Conversation

tgucio
Copy link
Contributor

@tgucio tgucio commented Feb 22, 2023 •
edited
Loading

This PR removes the TODO comment from #109729 as trailing null char was removed.

test-exempt: removed comment only

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 22, 2023
@tgucio
Copy link
Contributor Author

tgucio commented Feb 22, 2023

@cbracken @yaakovschectman This is the remaining suggestion from the review in #109729.

cbracken
cbracken approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 22, 2023

auto label is removed for flutter/flutter, pr: 121200, due to - The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-commands-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tgucio tgucio added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit auto-submit bot merged commit f85a75d into flutter:master Feb 23, 2023
@tgucio tgucio deleted the utf-conf-todo branch February 23, 2023 09:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
4477574
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
e1027b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
e941e03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
c98ae28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
ea5c320
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
7f617d5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
4f614b0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
17b1ef9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
87f9e3d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
b7afcf6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
e4c9f2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
c6eb645
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
866fa43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
0ef53d7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
4959024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
87e0f55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
1eb0fce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
0d8ffff
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
27eda6c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
b51c3c1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
238c449
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
2d54c1f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f85a75d Remove outdated TODO (flutter/flutter#121200)
04e9e66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgucio @cbracken @yaakovschectman