[flutter_tools] remove late from update-packages command #121891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
| @@ -1274,8 +1285,7 @@ class PubspecDependency extends PubspecLine { | |||
| /// dependencies/dev_dependencies section, or a dependency_overrides section. | |||
| /// We track this so that we can put ourselves in the right section when | |||
| /// generating the fake pubspec.yaml. | |||
| bool get lockIsOverride => _lockIsOverride; | |||
| late bool _lockIsOverride; | |||
| bool? _lockIsOverride; | |||
There was a problem hiding this comment.
I deleted the public getter, since:
- all the logic for this is in a single library, so it didn't matter that it was public
- it obscured my editor reference list, since assignments were to the private field, but accesses were to the public getter.
Thus, by consolidating for a single field, I'm optimizing for my future sanity having to read this code
| isTransitive: isTransitive, | ||
| version: version, | ||
| kind: stripped.isEmpty ? DependencyKind.unknown : DependencyKind.normal, sourcePath: filename, | ||
| isDevDependency: isDevDependency, |
There was a problem hiding this comment.
only change here is adding this line, and then formatting
jmagman
approved these changes
Mar 3, 2023
christopherfujino
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99928
Manually tested by running
flutter update-packages --force-upgradeand it successfully recreated #121847