Fix menu width issue for DropdownMenu
#123823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
QuncCccccc
force-pushed
the
fix_menu_anchor_width
branch
from
525f09d to
bcf61ce
Compare
rydmike
reviewed
Apr 1, 2023
| @@ -826,6 +826,7 @@ class _DropdownMenuDefaultsM3 extends DropdownMenuThemeData { | |||
| return const MenuStyle( | |||
| minimumSize: MaterialStatePropertyAll<Size>(Size(_kMinimumWidth, 0.0)), | |||
| maximumSize: MaterialStatePropertyAll<Size>(Size.infinite), | |||
| visualDensity: VisualDensity.standard, | |||
There was a problem hiding this comment.
@QuncCccccc this seems partially a bit unrelated to the issue. It will make the menu unresponsive the general theme VisualDensity changes. Unless the used TextField in the DropdownMenu already is that as well already. Then it makes sense to make sure sizes always line up. Are all the other menus also locked and not changing with VisualDensity? If so (I will check) it makes even more sense. If we can avoid inconsistencies that is always nice. I have heard feedback from Flutter devs that were raging about inconsistencies in VisualDenisity behavior in general in Flutter, but that is another topic.
Nice find with the key, would have taken me a while to figure that out. Thanks for the quick fix.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #123631.
This PR is to fix the menu width. It should be the same width as the input field.
Borrow the same example that shows in the issue description:)
Pre-launch Checklist
///).