Skip to content

flutter tool: make FlutterOptions abstract final #124178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 6, 2023
Merged

flutter tool: make FlutterOptions abstract final #124178

merged 6 commits into from
Apr 6, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 5, 2023

Never meant to be instantiated, implemented, or extended

@kevmoo
flutter tool: make FlutterOptions abstract final
060067b 
Never meant to be instantiated, implemented, or extended
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 5, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@kevmoo kevmoo requested a review from christopherfujino April 5, 2023 02:07
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 5, 2023

Using those fun new Dart language features.

christopherfujino
christopherfujino approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 6, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 6, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit bot merged commit d062bfa into master Apr 6, 2023
@auto-submit auto-submit bot deleted the flutter_options_abstract_final branch April 6, 2023 05:34
zanderso added a commit that referenced this pull request Apr 6, 2023
@zanderso
Revert "flutter tool: make FlutterOptions abstract final (#124178)"
7eb25fb 
This reverts commit d062bfa.
@zanderso zanderso mentioned this pull request Apr 6, 2023
Merged
@auto-submit auto-submit bot mentioned this pull request Apr 6, 2023
Closed
@zanderso zanderso mentioned this pull request Apr 6, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2023
@engine-flutter-autoroll
d062bfa flutter tool: make FlutterOptions abstract final (flutter/flu…
599a1e9 
…tter#124178)
@kevmoo kevmoo mentioned this pull request Apr 6, 2023
Merged
kevmoo added a commit that referenced this pull request Apr 6, 2023
@kevmoo
flutter tool: make FlutterOptions abstract final
3c35a05 
Relands #124178 - d062bfa
Unlands #124303 - 419c1eb

flutter tool: make FlutterOptions abstract final
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@kevmoo @exaby73
flutter tool: make FlutterOptions abstract final (flutter#124178)
70ab68d 
flutter tool: make FlutterOptions abstract final
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d062bfa flutter tool: make FlutterOptions abstract final (flutter/flu…
50cfafc 
…tter#124178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d062bfa flutter tool: make FlutterOptions abstract final (flutter/flu…
67739b4 
…tter#124178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @christopherfujino