-
Notifications
You must be signed in to change notification settings - Fork 28.6k
fix AppBar's docs for backgroundColor #126194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HansMuller
merged 1 commit into
flutter:master
from
werainkhatri:fix-appbar-bgcolor-docs
May 9, 2023
Merged
fix AppBar's docs for backgroundColor #126194
HansMuller
merged 1 commit into
flutter:master
from
werainkhatri:fix-appbar-bgcolor-docs
May 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
camsim99
pushed a commit
to flutter/packages
that referenced
this pull request
May 12, 2023
flutter/flutter@8c5a1ea...a76dbe4 2023-05-10 [email protected] Manual roll Flutter Engine from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392) 2023-05-10 [email protected] Roll flutter/packages to 0167d83 (flutter/flutter#126427) 2023-05-10 [email protected] Migrate gallery ios tests to build+test (flutter/flutter#111164) 2023-05-09 [email protected] Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360) 2023-05-09 [email protected] Revert "Provide default constraints for M3 dialogs" (flutter/flutter#126355) 2023-05-09 [email protected] Roll Packages from 4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352) 2023-05-09 [email protected] [github] Add labeler action (flutter/flutter#126012) 2023-05-09 [email protected] Fix platformLocation path and search dropping (flutter/flutter#126232) 2023-05-09 [email protected] Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309) 2023-05-09 [email protected] Update FocusNode documentation (flutter/flutter#126331) 2023-05-09 [email protected] Remove dead code (flutter/flutter#126266) 2023-05-09 [email protected] fix AppBar's docs for backgroundColor (flutter/flutter#126194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@8c5a1ea...a76dbe4 2023-05-10 [email protected] Manual roll Flutter Engine from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392) 2023-05-10 [email protected] Roll flutter/packages to 0167d83 (flutter/flutter#126427) 2023-05-10 [email protected] Migrate gallery ios tests to build+test (flutter/flutter#111164) 2023-05-09 [email protected] Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360) 2023-05-09 [email protected] Revert "Provide default constraints for M3 dialogs" (flutter/flutter#126355) 2023-05-09 [email protected] Roll Packages from 4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352) 2023-05-09 [email protected] [github] Add labeler action (flutter/flutter#126012) 2023-05-09 [email protected] Fix platformLocation path and search dropping (flutter/flutter#126232) 2023-05-09 [email protected] Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309) 2023-05-09 [email protected] Update FocusNode documentation (flutter/flutter#126331) 2023-05-09 [email protected] Remove dead code (flutter/flutter#126266) 2023-05-09 [email protected] fix AppBar's docs for backgroundColor (flutter/flutter#126194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the documentation in question:
flutter/packages/flutter/lib/src/material/app_bar.dart
Lines 135 to 142 in 7c356d0
series of events:
AppBar
andTextButton
and a troubleshooting section was added to the docs (PR) explaining the situation and providing a remedy.before the M3 migration, the doc made sense. but after, it needed to specify which material version does this issue occur in.
also, M3 default of
ButtonStyle.foregroundColor
forTextButton
is stillColorScheme.primary
(except for the disabled state, where itsColorScheme.onSurface
) and default forAppBar.backgroundColor
is nowColorScheme.surface
, the issue explained in the doc does not occur in M3.flutter/packages/flutter/lib/src/material/text_button.dart
Lines 556 to 562 in 7c356d0
Fixes #126168
Pre-launch Checklist
///
).