Skip to content

Add debugging for Dart VM timeout flake #126437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2023
Merged

Add debugging for Dart VM timeout flake #126437

merged 5 commits into from
May 15, 2023

Conversation

vashworth
Copy link
Contributor

Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.

Debugging for #121231.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 10, 2023
@vashworth vashworth changed the title Add debugging for dart vm timeout flake Add debugging for Dart VM timeout flake May 10, 2023
@vashworth
Copy link
Contributor Author

I described this in the comments in the code, but FYI:

The expected files to be found in the device's iOS DeviceSupport include Symbols (directory), Info.plist, and .finalized.

If any of the expected files are missing or there are additional files (such as .copying_lock or .processing_lock), this may indicate the symbols may still be fetching or something went wrong when fetching them.

@vashworth vashworth mentioned this pull request May 10, 2023
Closed
@vashworth vashworth requested a review from hellohuanlin May 11, 2023 16:34
hellohuanlin
hellohuanlin approved these changes May 11, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed May 12, 2023
View reviewed changes
christopherfujino
christopherfujino approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about adding a bit more context to one trace, but LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot merged commit 5d11325 into flutter:master May 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
358529c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
1df5aa3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
7ded3d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
94ff494
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
b48ec6b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
36866da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
52d6622
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
f245555
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
8fd974a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
1dc19dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
cac4d3d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
b4cd681
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
b100d63
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
75b1cf0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
ec01856
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
bfc5cbe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
a6f8f8f
@vashworth vashworth mentioned this pull request May 16, 2023
Closed
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@vashworth
Add debugging for Dart VM timeout flake (flutter#126437)
0689c57 
Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.

Debugging for flutter#121231.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
7a3530c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
378b4d1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
bfadf5d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5d11325 Add debugging for Dart VM timeout flake (flutter/flutter#126437)
804a829
@vashworth vashworth deleted the dart_vm_timeout_debug branch September 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vashworth @christopherfujino @hellohuanlin