-
Notifications
You must be signed in to change notification settings - Fork 28.6k
enable no_literal_bool_comparisons lint #126647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @pq for the awesome quick fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cool!
@@ -1009,7 +1009,7 @@ class FlutterError extends Error with DiagnosticableTreeMixin implements Asserti | |||
isInDebugMode = true; | |||
return true; | |||
}()); | |||
final bool reportError = isInDebugMode || details.silent != true; // could be null | |||
final bool reportError = isInDebugMode || !details.silent; // could be null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: #126927
Follow-up to #126647 (comment).
Partial revert of #126647 to work around issue in google3. See b/283046390
Partial revert of flutter#126647 to work around issue in google3. See b/283046390
No description provided.