-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Fix typing to unblock pub roll #144968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing to unblock pub roll #144968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to this.
(Major version change in package:web)
(/cc @srujzs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/flutter/144968, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Manual roll requested by [email protected] flutter/flutter@61812ca...394269f 2024-03-12 [email protected] Manual roll Flutter Engine from 6cefbe183546 to 67713071563e (5 revisions) (flutter/flutter#145002) 2024-03-12 [email protected] add missing `await`s (flutter/flutter#144978) 2024-03-12 [email protected] Write unit tests for API Examples of checkbox.0, checkbox.1 (flutter/flutter#144888) 2024-03-12 [email protected] Fix typing to unblock pub roll (flutter/flutter#144968) 2024-03-12 [email protected] Manual roll Flutter Engine from 6745955bb49e to 6cefbe183546 (6 revisions) (flutter/flutter#144996) 2024-03-12 [email protected] Roll Packages from d489d84 to d1aeb26 (3 revisions) (flutter/flutter#144994) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The pub roller is blocked on
See #144852.
The fixes the typing so the next pub roll can (hopefully) succeed.