Fix typing to unblock pub roll #144968
Merged
Fix typing to unblock pub roll #144968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
(/cc @srujzs) |
goderbauer
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/144968, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
srujzs
approved these changes
Mar 12, 2024
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 13, 2024
Manual roll requested by [email protected] flutter/flutter@61812ca...394269f 2024-03-12 [email protected] Manual roll Flutter Engine from 6cefbe183546 to 67713071563e (5 revisions) (flutter/flutter#145002) 2024-03-12 [email protected] add missing `await`s (flutter/flutter#144978) 2024-03-12 [email protected] Write unit tests for API Examples of checkbox.0, checkbox.1 (flutter/flutter#144888) 2024-03-12 [email protected] Fix typing to unblock pub roll (flutter/flutter#144968) 2024-03-12 [email protected] Manual roll Flutter Engine from 6745955bb49e to 6cefbe183546 (6 revisions) (flutter/flutter#144996) 2024-03-12 [email protected] Roll Packages from d489d84 to d1aeb26 (3 revisions) (flutter/flutter#144994) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pub roller is blocked on
See #144852.
The fixes the typing so the next pub roll can (hopefully) succeed.