Add `mouseCursor` parameter to `ReorderableListView` #160246

ValentinVignal · 2024-12-13T16:01:59Z

Defautl	Customized
Screen.Recording.2024-12-13.at.11.37.02.PM.mov	Screen.Recording.2024-12-13.at.11.41.04.PM.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ValentinVignal · 2024-12-13T16:03:01Z

@dkwingsmt is this what you were expecting for ReorderableListView?

Piinks

Hi @ValentinVignal, glad to see you!

Flyby comment from triage, it looks like the docs test shard is failing.

ValentinVignal · 2024-12-27T12:07:12Z

Thank you for the notice @Piinks. I'm not sure this PR is valid or what @dkwingsmt expected. Maybe we'll close it. I was thinking of putting more efforts into this once it is confirmed we are moving forward with it :)

dkwingsmt

Sorry, this PR somehow missed my attention. The WidgetState mouse cursor looks good to me, but I think the approach can be much simpler.

dkwingsmt · 2024-12-27T19:27:37Z

packages/flutter/lib/src/material/reorderable_list.dart

+  /// If [mouseCursor] is a [WidgetStateMouseCursor],
+  /// [WidgetStateProperty.resolve] is used for the following [WidgetState]s:
+  ///
+  ///  * [WidgetState.hovered].


Hovered should not be needed since cursors don't make sense unless hovered :)

Makes sense, I've simplified it in refactor: Simplify code

dkwingsmt · 2024-12-27T19:29:25Z

packages/flutter/lib/src/material/reorderable_list.dart

+                WidgetState.hovered: SystemMouseCursors.grab,
+              }),
+              <WidgetState>{
+                if (_dragIndex.value == index)


Do we really need this? We only need to know whether the widget is being dragged at all, because the mouse will definitely be on the item being dragged.

You are right! I made the code simpler in refactor: Simplify code

Piinks · 2025-01-08T18:18:20Z

Hey @ValentinVignal, noticing in triage here, it looks like this PR is failing some checks. Can you take a look?

dkwingsmt

LGTM, thank you for the contribution!

Piinks

LGTM to me as well! Thank you!

Piinks · 2025-01-09T20:03:40Z

Rebased to resolve a CI issue.

…/flutter#160246)

Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) flutter/flutter@4b23b81...864d4f5 2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997) 2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998) 2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996) 2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999) 2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000) 2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349) 2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391) 2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392) 2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400) 2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344) 2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404) 2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401) 2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379) 2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246) 2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396) 2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525) 2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394) 2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307) 2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331) 2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276) 2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389) 2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196) 2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567) 2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354) 2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278) 2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347) 2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637) 2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199) 2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342) 2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339) 2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184) 2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287) 2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275) 2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270) 2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109) 2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263) 2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326) 2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978) 2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032) 2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318) 2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277) 2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292) ...

victorsanni · 2025-01-17T17:59:16Z

Reason for revert: Causing the tree to go red. See #161815.

auto-submit · 2025-01-17T17:59:28Z

Time to revert pull request flutter/flutter/160246 has elapsed.
You need to open the revert manually and process as a regular pull request.

…/flutter#160246)

justinmc · 2025-02-25T00:43:31Z

The test failure that this PR caused was fixed in: #161836

victorsanni · 2025-02-25T00:59:57Z

The test failure that this PR caused was fixed in: #161836

Funny coincidence actually... This PR was perfect 👍 The test failure had existed for a long time, but it never came to light until a random daily reordering triggered it, but only in the tests added in this PR.

…/flutter#160246)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 13, 2024

ValentinVignal requested a review from dkwingsmt December 13, 2024 16:04

Piinks reviewed Dec 18, 2024

View reviewed changes

dkwingsmt reviewed Dec 27, 2024

View reviewed changes

ValentinVignal force-pushed the flutter/Add-mouse-cursor-parameter-to-reorderable-list-view branch from 229a19b to 318d573 Compare December 28, 2024 05:01

ValentinVignal requested review from dkwingsmt and Piinks December 28, 2024 05:02

ValentinVignal force-pushed the flutter/Add-mouse-cursor-parameter-to-reorderable-list-view branch from 8edd40b to 362d510 Compare January 9, 2025 12:11

dkwingsmt approved these changes Jan 9, 2025

View reviewed changes

Piinks approved these changes Jan 9, 2025

View reviewed changes

ValentinVignal added 5 commits January 9, 2025 14:03

feat: Add mouse cursor parameter to ReorderableListView

c943165

test: Add tests

5aaa234

refactor: Simplify code

cabe51b

test: Update the tests

51fe18e

format: Format files

7f9d04d

Piinks force-pushed the flutter/Add-mouse-cursor-parameter-to-reorderable-list-view branch from 362d510 to 7f9d04d Compare January 9, 2025 20:03

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

auto-submit bot added this pull request to the merge queue Jan 9, 2025

Merged via the queue into flutter:master with commit 34081dc Jan 9, 2025
104 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

engine-flutter-autoroll mentioned this pull request Jan 10, 2025

Roll Flutter from 4b23b8182888 to 864d4f59dde0 (50 revisions) flutter/packages#8407

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

123af2d

…/flutter#160246)

engine-flutter-autoroll mentioned this pull request Jan 10, 2025

Roll Flutter from 4b23b8182888 to 864d4f59dde0 (50 revisions) flutter/packages#8408

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

0dffd40

…/flutter#160246)

Piinks mentioned this pull request Jan 11, 2025

Flutter Notable Commits - 2025 #161460

Open

victorsanni added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 17, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 17, 2025

victorsanni added a commit to victorsanni/flutter that referenced this pull request Jan 17, 2025

Revert flutter#160246 "Add mouseCursor parameter to ReorderableListView"

181a5f1

victorsanni mentioned this pull request Jan 17, 2025

Revert #160246 "Add mouseCursor parameter to ReorderableListView" #161819

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

c406dec

…/flutter#160246)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

d507b93

…/flutter#160246)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

b3aeee8

…/flutter#160246)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

692c699

…/flutter#160246)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

34081dc Add mouseCursor parameter to ReorderableListView (flutter…

e8a25ad

…/flutter#160246)

Add mouseCursor parameter to ReorderableListView #160246

Add mouseCursor parameter to ReorderableListView #160246

Uh oh!

Conversation

ValentinVignal commented Dec 13, 2024

Pre-launch Checklist

Uh oh!

ValentinVignal commented Dec 13, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Dec 27, 2024

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Dec 28, 2024

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Dec 28, 2024

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jan 8, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jan 9, 2025

Uh oh!

Uh oh!

victorsanni commented Jan 17, 2025

Uh oh!

auto-submit bot commented Jan 17, 2025

Uh oh!

justinmc commented Feb 25, 2025

Uh oh!

victorsanni commented Feb 25, 2025

Uh oh!

Uh oh!

Add `mouseCursor` parameter to `ReorderableListView` #160246

Add `mouseCursor` parameter to `ReorderableListView` #160246