Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android #161546

gmackall · 2025-01-13T20:52:53Z

Makes it so that stripped defaults to false for android in gn arguments, i.e. we don't strip the Android engine builds. AGP does this by default when the NDK is installed (and we download it automatically now after #159756).

In testing, the step that AGP does to strip symbols adds ~1-2 seconds to the build.

Adds a tool verification for release app bundle builds that checks to make sure we have stripped the debug symbols and placed them in the BUNDLE-METADATA directory. The check is done by invoking apkanalyzer, which takes ~0.5 seconds, which is why the check is only enabled for release builds.

BEFORE LANDING: I need to follow up on flutter/engine#50443 (comment), to ensure we start stripping symbols internally as well.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/src/android/gradle.dart

reidbaker · 2025-01-30T16:22:27Z

packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

+        processManager.addCommand(
+          const FakeCommand(
+            command: <String>[
+              'gradlew',


There are a lot of flags here that probably came from the flutter tool. Later when the tool is changed and we need to update this test it will be harder to figure out why.

link where you came up with these flags and their values.

Pulled out to a constant which will make updating easy. For where they came from, I just copied them from the existing tests. I can go find where all the flags come from if you think it is worthwhile

packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

bkonyi

I think we can share a lot of the logic between tests, so it's probably worth taking another look and refactoring them.

packages/flutter_tools/lib/src/android/gradle.dart

packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

remake engine pr changing default for symbol stripping on android

cb9d6c7

gmackall mentioned this pull request Jan 13, 2025

Remove default for stripped option, don't strip by default on android flutter/engine#52852

Closed

8 tasks

github-actions bot added the engine flutter/engine repository. See also e: labels. label Jan 13, 2025

gmackall and others added 4 commits January 27, 2025 08:53

Merge branch 'master' into remake_dont_strip_android_symbols

83a2a40

Merge branch 'flutter:master' into remake_dont_strip_android_symbols

8dfb472

Merge branch 'flutter:master' into remake_dont_strip_android_symbols

49fc677

start for enforcing app bundles have debug symbols included

8adad84

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 29, 2025

Gray Mackall and others added 13 commits January 29, 2025 12:34

enforce check, format

0be2826

only verify this for aab

d6e1f1e

Merge branch 'master' into remake_dont_strip_android_symbols

4cdf4cf

push missed name change

74877d6

apply to each architecture, and make only for release

6350337

format

7ab7370

only test for at least one arch, instead of all

d0d975f

its apkanalyzer.bat on windows

17f0772

add tests

f46259e

fix test name

6e5fcff

test to ensure we don't invoke apkanalyzer in debug

1b9913f

make the test not hardcoded

3b1b7b9

format

4cae103

gmackall marked this pull request as ready for review January 30, 2025 01:22

Merge branch 'master' into remake_dont_strip_android_symbols

f5ee7bc

gmackall requested review from a team and bkonyi January 30, 2025 15:34

gmackall changed the title ~~[remake] Remove default for stripped option, don't strip by default on android~~ Remove default for stripped option in engine/src/flutter/tools/gn, don't strip by default on android Jan 30, 2025

reidbaker reviewed Jan 30, 2025

View reviewed changes

pull out common portions of test gradle command, and use a group

0a3ab63

bkonyi reviewed Jan 30, 2025

View reviewed changes

pull apkanalyzer output to top group level

7b1201b

engine-flutter-autoroll mentioned this pull request Feb 4, 2025

Roll Flutter from 8e2a6fc3fd2c to e7bdde653423 (26 revisions) flutter/packages#8565

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

ab5a9d0

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

4c9c2f4

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to dfb36f032e6d (46 revisions) flutter/packages#8568

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

4865f68

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Flutter from 8e2a6fc3fd2c to dfb36f032e6d (46 revisions) flutter/packages#8569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

520db00

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

gnprice mentioned this pull request Feb 5, 2025

CI failing in Android build as out of memory zulip/zulip-flutter#1330

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

311660c

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

422c287

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

59cac83

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

c48d2ee

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

d22f204

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

9bbafdb

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

e354e7b

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

8a06ce2

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

f15af45

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

a2cef5e

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

738a15f

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

9cf5ed9

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

8071506

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

ba8ca9b

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

1b00a8e

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

21bf33e

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

6131f72

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

7b3ae3e

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

c196eff

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

58196bd

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

df114fb Remove default for stripped option in `engine/src/flutter/too…

287c6b8

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

gmackall mentioned this pull request Mar 3, 2025

et: debug binaries are stripped on linux #153585

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android #161546

Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android #161546

gmackall commented Jan 13, 2025 •

edited

Loading

reidbaker Jan 30, 2025

gmackall Jan 30, 2025

bkonyi left a comment

Remove default for stripped option in engine/src/flutter/tools/gn, don't strip by default on android #161546

Remove default for stripped option in engine/src/flutter/tools/gn, don't strip by default on android #161546

Conversation

gmackall commented Jan 13, 2025 • edited Loading

Pre-launch Checklist

reidbaker Jan 30, 2025

Choose a reason for hiding this comment

gmackall Jan 30, 2025

Choose a reason for hiding this comment

bkonyi left a comment

Choose a reason for hiding this comment

Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android #161546

Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android #161546

gmackall commented Jan 13, 2025 •

edited

Loading