Last Engine<>Framework lint sync #161560

goderbauer · 2025-01-13T23:11:55Z

This is the last time we have to do this because in #161554 I am refactoring the engine's analysis_options.yaml to just import the one from the root of the repository. When that lands, lints only have to be enabled in one place to apply across framework and engine.

Before we can do that we have to do one last sync to make sure the engine code base is ready. This PR implements that last sync and fixing all lints that came up.

ditman

Looks good to me! I want to re-enable the invalid_runtime_check_with_js_interop_types lint at some point, I'll create a follow-up issue for that!

engine/src/flutter/lib/web_ui/lib/src/engine/platform_dispatcher/app_lifecycle_state.dart

Now that we have a monorepo we can vastly simplify the engine's `analysis_options.yaml` file: It can just import the general rule set (instead of recreating it) and then we can apply the engine-specific rules on top of it. This also makes it easier to tell where the engine rule set differs from the general one. No more `# DIFFERENT FROM FLUTTER/FLUTTER` comments. 🥳 Depends on #161560, which has to be submitted first.

This is the last time we have to do this because in flutter#161554 I am refactoring the engine's analysis_options.yaml to just import the one from the root of the repository. When that lands, lints only have to be enabled in one place to apply across framework and engine. Before we can do that we have to do one last sync to make sure the engine code base is ready. This PR implements that last sync and fixing all lints that came up.

Now that we have a monorepo we can vastly simplify the engine's `analysis_options.yaml` file: It can just import the general rule set (instead of recreating it) and then we can apply the engine-specific rules on top of it. This also makes it easier to tell where the engine rule set differs from the general one. No more `# DIFFERENT FROM FLUTTER/FLUTTER` comments. 🥳 Depends on flutter#161560, which has to be submitted first.

flutter/flutter@40c2b86...5517cc9 2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680) 2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672) 2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643) 2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632) 2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

WIP

a138235

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Jan 13, 2025

goderbauer changed the title ~~WIP~~ Last Engine<>Framework lint sync Jan 13, 2025

goderbauer requested a review from ditman January 13, 2025 23:58

goderbauer mentioned this pull request Jan 13, 2025

Clean up engine's analysis_options.yaml #161554

Merged

ditman approved these changes Jan 14, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/lib/src/engine/platform_dispatcher/app_lifecycle_state.dart Show resolved Hide resolved

goderbauer added this pull request to the merge queue Jan 14, 2025

ditman mentioned this pull request Jan 14, 2025

[web] Enable invalid_runtime_check_with_js_interop_types lint in web_ui code. #161617

Open

Merged via the queue into flutter:master with commit 3da003c Jan 14, 2025
177 checks passed

goderbauer deleted the lintSync branch January 14, 2025 21:42

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 2b34d78c2331 (20 revisions) flutter/packages#8435

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

693234e

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 44ff2f59774b (22 revisions) flutter/packages#8436

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

c4d2452

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 1580a3d3fbe7 (23 revisions) flutter/packages#8437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

cb1485f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

5157da7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

f77793e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

a7379e0

engine-flutter-autoroll mentioned this pull request Jan 16, 2025

Roll Flutter from 40c2b86fdf65 to 5517cc9b3b3b (28 revisions) flutter/packages#8444

Closed

This was referenced Jan 16, 2025

Roll Flutter from 40c2b86fdf65 to 5517cc9b3b3b (28 revisions) flutter/packages#8445

Closed

Roll Flutter from 40c2b86fdf65 to 5517cc9b3b3b (28 revisions) flutter/packages#8446

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

b4c0d40

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

833ba88

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

2c1d92f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

36eede3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

ac60413

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

33c4383

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

a009709

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

b6e8dea

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

1decd69

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

211c66d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

3da003c Last Engine<>Framework lint sync (flutter/flutter#161560)

a637f94

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Last Engine<>Framework lint sync #161560

Last Engine<>Framework lint sync #161560

Uh oh!

goderbauer commented Jan 13, 2025 •

edited

Loading

Uh oh!

ditman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Last Engine<>Framework lint sync #161560

Last Engine<>Framework lint sync #161560

Uh oh!

Conversation

goderbauer commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Jan 13, 2025 •

edited

Loading