[Android] SurfaceTransaction updates for HC++. #162405
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
| /// created by the flutter engine or was borrowed from Java for platform | ||
| /// interop. | ||
| struct WrappedSurfaceTransaction { | ||
| ASurfaceTransaction* tx; |
| /// interop. | ||
| struct WrappedSurfaceTransaction { | ||
| ASurfaceTransaction* tx; | ||
| bool owned; |
There was a problem hiding this comment.
true is the safer default here but roger.
| [](void* context, ASurfaceTransactionStats* stats) -> void { | ||
| auto data = reinterpret_cast<TransactionInFlightData*>(context); | ||
| data->callback(stats); | ||
| delete data; | ||
| }); | ||
| proc_table.ASurfaceTransaction_apply(transaction_.get()); | ||
| // If the transaction was created in Java, then it must be applied in | ||
| // the java PlatformViewController and not as a part of the engine render |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Adds but does not use the ability to use imported Java SurfaceTransactions in the AHB swapchain. When an imported SurfaceTransaction is used, the Swapchain will not apply the transaction and instead will rely on the PlatformViewController to do so.