Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function. #162578

ksokolovskyi · 2025-02-02T14:53:39Z

Fixes #162577

Description

Adds role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function.
Adds SemanticsNode.debugIsDirty property to check in tests whether the node is marked as dirty.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

…tion function.

chunhtai

LGTM

chunhtai · 2025-02-05T21:00:45Z

packages/flutter/lib/src/semantics/semantics.dart

@@ -2471,7 +2487,7 @@ class SemanticsNode with DiagnosticableTreeMixin {
        _areUserActionsBlocked != config.isBlockingUserActions ||
        _headingLevel != config._headingLevel ||
        _linkUrl != config._linkUrl ||
-        _linkUrl != config._linkUrl;


oops, nice catch. I made a copy paste error

hannah-hyj

LGTM

…icAnnotation function. (flutter/flutter#162578)

ksokolovskyi · 2025-02-06T21:28:28Z

@chunhtai @hannah-hyj, thanks a lot for the review!

…icAnnotation function. (flutter/flutter#162578)

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnota…

a2fee38

…tion function.

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Feb 2, 2025

goderbauer requested a review from chunhtai February 4, 2025 23:05

chunhtai approved these changes Feb 5, 2025

View reviewed changes

chunhtai requested a review from hannah-hyj February 5, 2025 21:01

hannah-hyj approved these changes Feb 5, 2025

View reviewed changes

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025

auto-submit bot added this pull request to the merge queue Feb 5, 2025

Merged via the queue into flutter:master with commit 243413f Feb 5, 2025
76 of 77 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to f219bbac5514 (67 revisions) flutter/packages#8576

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

e78c4aa

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to f219bbac5514 (67 revisions) flutter/packages#8577

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

a77bdb1

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to 0e59f0f64c6a (68 revisions) flutter/packages#8579

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

f5ad21a

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 6, 2025

Roll Flutter from 8e2a6fc3fd2c to 5944d992ac40 (69 revisions) flutter/packages#8581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

80c5468

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 7, 2025

Roll Flutter from 8e2a6fc3fd2c to 44203b67f5fd (81 revisions) flutter/packages#8583

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

eaba6cc

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 7, 2025

Roll Flutter from 8e2a6fc3fd2c to 44203b67f5fd (81 revisions) flutter/packages#8584

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

efd67d1

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 7, 2025

Roll Flutter from 8e2a6fc3fd2c to 892f9c13a2bb (84 revisions) flutter/packages#8585

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

39a4536

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 8, 2025

Roll Flutter from 8e2a6fc3fd2c to 829fe68e9dff (100 revisions) flutter/packages#8589

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

6b9a2b2

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 8, 2025

Roll Flutter from 8e2a6fc3fd2c to 829fe68e9dff (100 revisions) flutter/packages#8591

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

68b6c1d

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 9, 2025

Roll Flutter from 8e2a6fc3fd2c to 5156de731b45 (102 revisions) flutter/packages#8593

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

76de494

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 9, 2025

Roll Flutter from 8e2a6fc3fd2c to 5156de731b45 (102 revisions) flutter/packages#8594

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

6f2d697

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 10, 2025

Roll Flutter from 8e2a6fc3fd2c to e7cb7a30bb1c (104 revisions) flutter/packages#8597

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

da73817

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 10, 2025

Roll Flutter from 8e2a6fc3fd2c to c89d563944e3 (105 revisions) flutter/packages#8599

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

2646eb5

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 10, 2025

Roll Flutter from 8e2a6fc3fd2c to 33a4c95de079 (106 revisions) flutter/packages#8600

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

fb3266a

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 10, 2025

Roll Flutter from 8e2a6fc3fd2c to 1d766ed8d93e (107 revisions) flutter/packages#8601

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

8bdac98

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll mentioned this pull request Feb 10, 2025

Roll Flutter from 8e2a6fc3fd2c to 78e5d7995cdb (108 revisions) flutter/packages#8602

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

70440a9

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

db2c8ff

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

bd5fc66

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

b1c7c7d

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

f1f866b

…icAnnotation function. (flutter/flutter#162578)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025

243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…

a12a508

…icAnnotation function. (flutter/flutter#162578)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function. #162578

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function. #162578

ksokolovskyi commented Feb 2, 2025

chunhtai left a comment

chunhtai Feb 5, 2025

hannah-hyj left a comment

ksokolovskyi commented Feb 6, 2025

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function. #162578

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function. #162578

Conversation

ksokolovskyi commented Feb 2, 2025

Description

Pre-launch Checklist

chunhtai left a comment

Choose a reason for hiding this comment

chunhtai Feb 5, 2025

Choose a reason for hiding this comment

hannah-hyj left a comment

Choose a reason for hiding this comment

ksokolovskyi commented Feb 6, 2025