Skip to content

Use recompile-restart instruction when hot restarting on the web #162616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 4, 2025
Merged

Use recompile-restart instruction when hot restarting on the web #162616

merged 6 commits into from
Feb 4, 2025

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Feb 3, 2025 •
edited
Loading

recompile has been split into recompile and recompile-restart in the frontend server so that DDC can distinguish between hot reload recompiles and hot restart recompiles, and therefore emit rejection errors only on hot reload.

dart-lang/webdev#2516

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@srujzs
Use recompile-restart instruction when hot restarting on the web
f824b76 
recompile has been split into recompile and recompile-restart in
the frontend server so that DDC can distinguish between hot reload
recompiles and hot restart recompiles, and therefore emit rejection
errors only on hot reload.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 3, 2025
@srujzs srujzs requested a review from nshahan February 3, 2025 19:05
@srujzs
Copy link
Contributor Author

srujzs commented Feb 3, 2025

FYI - this will need #162259 before it can land.

@srujzs srujzs enabled auto-merge February 4, 2025 17:31
@srujzs srujzs added this pull request to the merge queue Feb 4, 2025
Merged via the queue into flutter:master with commit 5157d23 Feb 4, 2025
138 checks passed
@srujzs srujzs deleted the recres branch February 4, 2025 22:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
676c418 
…web (flutter/flutter#162616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
0488847 
…web (flutter/flutter#162616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
68d85ba 
…web (flutter/flutter#162616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
db98bb5 
…web (flutter/flutter#162616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
328b500 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
257dccc 
…web (flutter/flutter#162616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
60b39e8 
…web (flutter/flutter#162616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
7b55642 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
1916768 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
5237372 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
44ee943 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
0bd00cc 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
ddfd44d 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
bbfafd2 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
61c29ba 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
49b8c4b 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
28976f6 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
e104bd0 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
266201d 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
fee85ab 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
5c6046f 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
08fc531 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
cf2d5e0 
…web (flutter/flutter#162616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
5157d23 Use recompile-restart instruction when hot restarting on the …
df1db6c 
…web (flutter/flutter#162616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srujzs @nshahan