Switch iOS gen_snapshot from multi-arch binary to multiple binaries #37445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of flutter/engine#10430, we no longer combine the iOS armv7 and arm64 gen_snapshots into a single binary. Instead they're uploaded as two separate binaries in the same directory (https://chromium-review.googlesource.com/c/chromium/tools/build/+/1731443). So this change chooses the gen_snapshot to match the iosArch.
Related Issues
#22598
Tests
I built the flutter examples in this mode using Xcode 10 and verified that they work on an iPhone 4S.
Manual roll
git log b41c172..eac7ef0 --no-merges --oneline
flutter/engine@eac7ef065 Add copy_gen_snapshots.py tool (flutter/engine#10430)
flutter/engine@c3cc104e1 Fix mac gen_snapshot uploader (flutter/engine#10423)
flutter/engine@310bc030b Make kernel compiler use host toolchain (flutter/engine#10419)
flutter/engine@9fca3c744 Use simarm_x64 when targeting arm (flutter/engine#10010)
flutter/engine@bf9288597 [fuchsia] Add kernel_compiler target in build_fuchsia script (flutter/engine#10403)