Skip to content

TextSelectionTheme support (step 3 of 3) #66482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

darrenaustin
Copy link
Contributor

Description

This PR completes the migration to the new TextSelectionTheme started in #62014 and is described in the design doc.

This step changes makes the TextSelectionTheme always used for defaults by the TextField and SelectableText widgets. As such, the following parameters of the ThemeData are now deprecated and will eventually removed:

  • cursorColor
  • textSelectionColor
  • textSelectionHandleColor
  • useTextSelectionTheme

Related Issues

#17635
#56082
#61227

Tests

The tests were updated in the previous PR: #65044 this just removes and deprecates parameters already covered by these test updates.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

This step is not a breaking, but is part of a soft landing breaking change (see #62014 for more details).

  • No, no existing tests failed, so this is not a breaking change.

…pt-in flag and text selection properties in ThemeData.
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 23, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Ahh, much cleaner.

@darrenaustin
Copy link
Contributor Author

@andrewbyk, not sure what you are running into here. Can you open an issue with a runnable example of the issue you are seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants