Skip to content

Remove unused bigquery code and deps #74532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Remove unused bigquery code and deps #74532

merged 2 commits into from
Jan 23, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 22, 2021

This code is unused. It was part of an idea to track the time and flakiness of individual tests, but had some issues and has not been turned back on. We should just delete it and re-land it when we're ready to actually use it.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 22, 2021
@google-cla google-cla bot added the cla: yes label Jan 22, 2021
@dnfield
Copy link
Contributor Author

dnfield commented Jan 22, 2021

This also required rolling packages.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield merged commit 1b373f4 into flutter:master Jan 23, 2021
@dnfield dnfield deleted the drop_bq branch January 23, 2021 00:21
@dnfield
Copy link
Contributor Author

dnfield commented Jan 23, 2021

Ignored the google testing check because none of this code runs in google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants