[web_benchmarks] Report correct expected metrics for wasm by mdebbar · Pull Request #10236 · flutter/packages

mdebbar · 2025-10-15T19:01:41Z

Depends on flutter/flutter@2e51c3f which will be part of the 3.38.0 release.

gemini-code-assist

Code Review

This pull request correctly fixes an issue where expected metrics for Wasm benchmarks were incomplete. The change removes incorrect conditional logic, ensuring prerollFrame and applyFrame are always included. The useWasm parameter is now deprecated, which is a good cleanup. The package version and Flutter SDK constraints are also updated accordingly. I've found one minor issue in the CHANGELOG.md with a duplicate entry.

packages/web_benchmarks/CHANGELOG.md

packages/web_benchmarks/pubspec.yaml

stuartmorgan-g

LGTM

kevmoo · 2025-11-12T23:28:57Z

@mdebbar – gunna run w/ this?

stuartmorgan-g · 2025-11-13T15:18:14Z

Resolving dependencies...
The current Dart SDK version is 3.10.0-290.4.beta.

Because web_benchmarks requires SDK version ^3.10.0, version solving failed.

These CI failures are because of flutter/flutter#178400. Once the fix is published to stable we'll roll it into the flutter/packages stable pin.

mdebbar · 2025-11-13T20:37:16Z

Looks like Flutter 3.38.1 was released with the correct Dart SDK version. @stuartmorgan-g let me know what the next step is. Should I pin the web_benchmark package to 3.38.1?

stuartmorgan-g · 2025-11-13T21:07:22Z

You shouldn't need to change anything in the PR, rolling the pin forward for the repo should fix it. I'm about to start that process.

…utter/packages#10236)

flutter/packages@799b62c...ce44ebb 2025-11-17 jessiewong401@gmail.com Kgp bulk update (flutter/packages#10412) 2025-11-16 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 stuartmorgan@google.com [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 engine-flutter-autoroll@skia.org Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 engine-flutter-autoroll@skia.org Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 stuartmorgan@google.com [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 adilhanney@disroot.org [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 mdebbar@google.com [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 stuartmorgan@google.com [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

mdebbar added 2 commits October 15, 2025 14:43

[web_benchmarks] Report correct expected metrics for wasm

1f7d2c6

CHANGELOG

65cb112

mdebbar requested a review from yjbanov as a code owner October 15, 2025 19:01

github-actions bot added the p: web_benchmarks label Oct 15, 2025

mdebbar requested review from stuartmorgan-g and removed request for yjbanov October 15, 2025 19:01

gemini-code-assist bot reviewed Oct 15, 2025

View reviewed changes

stuartmorgan-g added the waiting for stable update Can't be landed until functionality reaches the stable channel label Oct 15, 2025

stuartmorgan-g requested changes Oct 21, 2025

View reviewed changes

packages/web_benchmarks/CHANGELOG.md Outdated Show resolved Hide resolved

packages/web_benchmarks/CHANGELOG.md Outdated Show resolved Hide resolved

packages/web_benchmarks/pubspec.yaml Outdated Show resolved Hide resolved

mdebbar added 2 commits October 23, 2025 15:12

Merge branch 'main' into use_wasm_frames

0ac502c

fix versions

2c09aee

stuartmorgan-g removed the waiting for stable update Can't be landed until functionality reaches the stable channel label Nov 12, 2025

Merge branch 'main' into use_wasm_frames

49edf48

stuartmorgan-g approved these changes Nov 12, 2025

View reviewed changes

stuartmorgan-g and others added 2 commits November 13, 2025 16:39

Merge branch 'main' into use_wasm_frames

ab28d36

format

14b9ff7

mdebbar mentioned this pull request Nov 13, 2025

Remove hardcoded useWasm: false for expectedBenchmarkMetrics() flutter/devtools#9518

Open

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2025

auto-submit bot merged commit 952418d into main Nov 14, 2025
80 checks passed

auto-submit bot deleted the use_wasm_frames branch November 14, 2025 00:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2025

952418d [web_benchmarks] Report correct expected metrics for wasm (fl…

0481cd6

…utter/packages#10236)

engine-flutter-autoroll mentioned this pull request Nov 14, 2025

Roll Packages from 799b62cc6dd5 to 952418ded43b (3 revisions) flutter/flutter#178530

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2025

952418d [web_benchmarks] Report correct expected metrics for wasm (fl…

6ea3a01

…utter/packages#10236)

engine-flutter-autoroll mentioned this pull request Nov 14, 2025

Roll Packages from 799b62cc6dd5 to 952418ded43b (3 revisions) flutter/flutter#178540

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2025

952418d [web_benchmarks] Report correct expected metrics for wasm (fl…

4eced29

…utter/packages#10236)

engine-flutter-autoroll mentioned this pull request Nov 17, 2025

Roll Packages from 799b62cc6dd5 to ce44ebb3c2af (10 revisions) flutter/flutter#178649

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[web_benchmarks] Report correct expected metrics for wasm#10236

[web_benchmarks] Report correct expected metrics for wasm#10236
auto-submit[bot] merged 7 commits intomainfrom
use_wasm_frames

mdebbar commented Oct 15, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

kevmoo commented Nov 12, 2025

Uh oh!

stuartmorgan-g commented Nov 13, 2025

Uh oh!

mdebbar commented Nov 13, 2025

Uh oh!

stuartmorgan-g commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

mdebbar commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

kevmoo commented Nov 12, 2025

Uh oh!

stuartmorgan-g commented Nov 13, 2025

Uh oh!

mdebbar commented Nov 13, 2025

Uh oh!

stuartmorgan-g commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mdebbar commented Oct 15, 2025 •

edited

Loading