[image_picker] Fix android-16 not picking up file#11320
Open
ashutosh2014 wants to merge 2 commits intoflutter:mainfrom
Open
[image_picker] Fix android-16 not picking up file#11320ashutosh2014 wants to merge 2 commits intoflutter:mainfrom
ashutosh2014 wants to merge 2 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses an issue on Android 16 (API 36) where the image picker would not return a file path. The solution is to enforce the use of the Android Photo Picker on API 36 and higher, which is implemented via a new utility method, effectiveUsePhotoPicker. This logic is consistently applied throughout the ImagePickerDelegate. The change is also accompanied by new unit tests, which is great. My review includes a minor suggestion to simplify the logic in the new utility method for improved conciseness.
...ge_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Fixes flutter/flutter#182071
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2