Skip to content

[animations] Add const to FadeScaleTransitionConfiguration #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

[animations] Add const to FadeScaleTransitionConfiguration #124

merged 1 commit into from
Apr 10, 2020

Conversation

@mono0926
Copy link
Contributor

@mono0926 mono0926 commented Mar 24, 2020 •
edited
Loading

Simply, added const to FadeScaleTransitionConfiguration.

goderbauer
goderbauer approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

@mono0926 Can you rebase this to the latest master to make the tests pass? Thanks!

@mono0926
Copy link
Contributor Author

@goderbauer

Can you rebase this to the latest master to make the tests pass?

I did it without any conflicts 👍

@goderbauer goderbauer merged commit c4706c7 into flutter:master Apr 10, 2020
@mono0926 mono0926 mentioned this pull request Apr 11, 2020
Merged
@mono0926 mono0926 deleted the add-const branch April 11, 2020 11:42
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
@dnfield
Do not draw strokes unless a stroke color, pattern, or gradient is sp…
6916130 
…ecified (#124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mono0926 @goderbauer