Repository navigation
[cupertino_ui] Read CupertinoTextFormFieldRow value from its controller - #12596
Draft
kaluli123123 wants to merge 1 commit into
Draft
kaluli123123 wants to merge 1 commit into
kaluli123123 wants to merge 1 commit into
Conversation
_CupertinoTextFormFieldRowState now overrides FormFieldState.value to read _effectiveController.text directly instead of relying on the cached value FormFieldState tracks internally. This guarantees validators (and FormField.onSaved) see the current text even when they run before this state has been notified of a controller change, for example when FormState.validate() is called from a controller listener that was registered before this field's own listener. Depends on the FormFieldState.isValid/validate() fix in flutter/flutter, which reads through the value getter instead of the private cached field. Ported from flutter/flutter#191658, which is blocked by the Cupertino code freeze. Fixes flutter/flutter#40494
github-actions
Bot
added
p: cupertino_ui
triage-design
8 tasks done
kaluli123123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_CupertinoTextFormFieldRowState now overrides FormFieldState.value to
read _effectiveController.text directly instead of relying on the cached
value FormFieldState tracks internally. This guarantees validators (and
FormField.onSaved) see the current text even when they run before this
state has been notified of a controller change, for example when
FormState.validate() is called from a controller listener that was
registered before this field's own listener.
Depends on the
FormFieldState.isValid/validate()fix in flutter/flutter#191708, which reads through the value getter instead of the private cached field. That framework PR is still open and unmerged; this package draft remains blocked on its integration into the SDK used by CI.Ported from flutter/flutter#191658, which is blocked by the Cupertino code freeze.
Fixes flutter/flutter#40494