Repository navigation
[cupertino_ui] Fix CupertinoExpansionTile skipping its fade when toggled by ExpansibleController - #13251
Open
master-wayne7 wants to merge 4 commits into
Open
[cupertino_ui] Fix CupertinoExpansionTile skipping its fade when toggled by ExpansibleController#13251master-wayne7 wants to merge 4 commits into
master-wayne7 wants to merge 4 commits into
Conversation
…led by ExpansibleController
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies CupertinoExpansionTile to listen to its controller's expansion state changes and trigger the fade transition, ensuring the transition occurs when toggled via an ExpansibleController. It also updates existing tests and adds a new test to verify this behavior. The review feedback suggests guarding the _fadeController.show() call in _handleExpansionChanged to only run when widget.transitionMode is ExpansionTileTransitionMode.fade to avoid redundant calls in other transition modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ExpansionTileTransitionMode.fade(the default),CupertinoExpansionTiledraws the fade with anOverlayPortalclone of the child, while the in-flow child is kept at zero opacity during the animation. The overlay was only shown from_onHeaderTap, so expanding or collapsing through anExpansibleController(controller.expand()/controller.collapse()) never showed it: the child popped in at the end of expansion and disappeared at the start of collapse.This PR makes the tile listen to its
ExpansibleControllerand show the fade overlay on every expansion change, whatever triggered it. The listener is moved over when the controller is swapped indidUpdateWidgetand removed indispose. The header-tap path no longer shows the overlay itself, since the listener now covers it.Tests:
Fades the child when toggled by ExpansibleController, which checks that the clone is mid-fade halfway through both expansion and collapse.Contentwidget aftercontroller.expand(). Header taps already produce two (the animating child plus the fading clone), so these expectations reflected the bug.Fixes flutter/flutter#194264
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2