-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[flutter_template_images] Add iOS app icon assets #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds the the AppIcon and LaunchImage assets in the iOS app template while simultaneously updating them to meet Apple's icon guidelines as of iOS. Ref: https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons#specifications Issue: flutter/flutter#106110
@jmagman Could you route this to a good reviewer for the icon changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This LGTM, but before we merge can you create a draft PR like flutter/flutter#103739 to allow this to be adopted in the template? Some tests will fail until this is published but if the tool PR is prepped then we can merge them close to the same time.
Can you also add some tests to prove the template is applying from this package (I know the referenced PR didn't have any tests).
Maybe around https://github.com/flutter/flutter/blob/0e0baa40c75fca3d119a821080038b45f1a3cf11/packages/flutter_tools/test/commands.shard/permeable/create_test.dart#L159
Hi @jmagman I've updated the PR for the flutter repository. flutter/flutter#106111 But I'm not sure how to prove that the template was applying from this package, so I haven't committed that part yet. I'm sorry for my lack of testing knowledge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR for the flutter repository. flutter/flutter#106111
Oh great, I didn't see that! This LGTM! Once this is published you can rebase or merge that one to re-run the tests, and we can work on adding one to create_test. Thanks for your contribution!
|
Validations Fail. |
Adding @stuartmorgan forgot I needed a second reviewer. |
Adds the the AppIcon and LaunchImage assets in the iOS app template while simultaneously updating them to meet Apple's icon guidelines as of iOS.
Ref:
https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons#specifications
Issue: flutter/flutter#106110
This is how the application icons are displayed in the settings list, obviously with black gaps in the four corners. This is because the mask Apple uses is not the standard rounded corners, but continuous corner.
This is a slow motion video of the app when it is opened from the home screen. The black color in the transition animation is caused by the transparent part of the icon.
This animation takes the colors of the left, bottom and right sides of the icon and then spreads the colors in all three directions, but the current icon has rounded corners, so some of the colors are missing.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).