Skip to content

[flutter_template_images] Add iOS app icon assets #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

RockerFlower
Copy link
Contributor

@RockerFlower RockerFlower commented Jun 20, 2022

Adds the the AppIcon and LaunchImage assets in the iOS app template while simultaneously updating them to meet Apple's icon guidelines as of iOS.

Ref:
https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons#specifications

Issue: flutter/flutter#106110


  1. This is how the application icons are displayed in the settings list, obviously with black gaps in the four corners. This is because the mask Apple uses is not the standard rounded corners, but continuous corner.

    icons in settings list

  2. This is a slow motion video of the app when it is opened from the home screen. The black color in the transition animation is caused by the transparent part of the icon.

    This animation takes the colors of the left, bottom and right sides of the icon and then spreads the colors in all three directions, but the current icon has rounded corners, so some of the colors are missing.

    video when open

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Adds the the AppIcon and LaunchImage assets in the iOS app template while
simultaneously updating them to meet Apple's icon guidelines as of iOS.

Ref:
https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons#specifications

Issue: flutter/flutter#106110
@stuartmorgan-g
Copy link
Contributor

@jmagman Could you route this to a good reviewer for the icon changes?

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
This LGTM, but before we merge can you create a draft PR like flutter/flutter#103739 to allow this to be adopted in the template? Some tests will fail until this is published but if the tool PR is prepped then we can merge them close to the same time.

Can you also add some tests to prove the template is applying from this package (I know the referenced PR didn't have any tests).
Maybe around https://github.com/flutter/flutter/blob/0e0baa40c75fca3d119a821080038b45f1a3cf11/packages/flutter_tools/test/commands.shard/permeable/create_test.dart#L159

@RockerFlower
Copy link
Contributor Author

Hi @jmagman

I've updated the PR for the flutter repository. flutter/flutter#106111

But I'm not sure how to prove that the template was applying from this package, so I haven't committed that part yet. I'm sorry for my lack of testing knowledge.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR for the flutter repository. flutter/flutter#106111

Oh great, I didn't see that! This LGTM! Once this is published you can rebase or merge that one to re-run the tests, and we can work on adding one to create_test. Thanks for your contribution!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

Validations Fail.

@jmagman jmagman requested a review from stuartmorgan-g July 7, 2022 23:35
@jmagman
Copy link
Member

jmagman commented Jul 7, 2022

Adding @stuartmorgan forgot I needed a second reviewer.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit auto-submit bot merged commit ecf45e1 into flutter:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_template_images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants