Skip to content

[ci] Migrate Cirrus tests to Apple Silicon #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 19, 2022

Run ios-platform_tests and macos-platform_tests on Apple Silicon Macs. Keep ios-custom_package_tests on Intel for now until Java installation flutter/flutter#109821 can be resolved.
Upgrade to macOS 12 Monterey and latest available Xcode 13.

Apple Silicon image options at https://github.com/cirruslabs/macos-image-templates/pkgs/container/macos-monterey-xcode

Fixes flutter/flutter#109819
See also plugin version of this at flutter/plugins#5794

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Aug 19, 2022
@jmagman jmagman added the team: infra Infrastructure like devicelab, Cirrus, or LUCI. label Aug 19, 2022
@jmagman
Copy link
Member Author

jmagman commented Aug 19, 2022

pigeon script failing due to missing Java runtime.

/private/var/folders/0d/08wbx2j52nx5hjg16cshb8g80000gn/T/cirrus-ci-build/packages/pigeon
/private/var/folders/0d/08wbx2j52nx5hjg16cshb8g80000gn/T/cirrus-ci-build/packages/pigeon /private/var/folders/0d/08wbx2j52nx5hjg16cshb8g80000gn/T/cirrus-ci-build/packages/pigeon
/private/var/folders/0d/08wbx2j52nx5hjg16cshb8g80000gn/T/cirrus-ci-build/packages/pigeon/run_tests.sh: line 38: [: too many arguments
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 55 11.8M   55 6799k    0     0  4404k      0  0:00:02  0:00:01  0:00:01 6494k
...
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.

https://cirrus-ci.com/task/6657444817403904?logs=local_tests#L2396

@fkorotkov is this an expected difference between the images, and our script needs to handle installing Java?

@jmagman jmagman marked this pull request as ready for review August 19, 2022 01:25
osx_instance:
image: big-sur-xcode-13
image: monterey-xcode-13.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe 13.4 is available.

@jmagman jmagman requested a review from stuartmorgan-g August 19, 2022 02:57
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2022
@auto-submit auto-submit bot merged commit 72feebe into flutter:main Aug 19, 2022
@jmagman jmagman deleted the arm-mac-tests branch August 19, 2022 16:54
johnpryan pushed a commit to johnpryan/flutter_packages that referenced this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App team: infra Infrastructure like devicelab, Cirrus, or LUCI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate packages repo Mac tests to Apple Silicon
2 participants