Skip to content

[ci] Roll Flutter master to 7b850ef37500 #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stuartmorgan-g
Copy link
Contributor

Fixing the failing roll; this rolls to the first failing hash to catch up incrementally.

@@ -27,3 +25,4 @@ dev_dependencies:
file_testing: ^3.0.0
lints: ^2.0.0
test: ^1.16.0
test_api: ^0.4.13
Copy link
Contributor Author

@stuartmorgan-g stuartmorgan-g Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaryQian I made the minimal changes to pick up the version of matcher (a transitive dependency) that fixes the roll, but do so many of the dependencies in this package actually need to be pinned, or is that just a legacy of this code coming from flutter/flutter? If the latter, we should make them all ^ range dependencies to make this package less fragile, otherwise this kind of roll breakage is going to keep happening.

@stuartmorgan-g stuartmorgan-g force-pushed the flutter-master-roll-2022-12-first-failing branch from a8a8cd5 to 2772c4b Compare December 21, 2022 15:18
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Dec 21, 2022
@stuartmorgan-g
Copy link
Contributor Author

Overriding version change for Pigeon, since it's a no-op change.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@auto-submit auto-submit bot merged commit f4e6a14 into flutter:main Dec 21, 2022
@stuartmorgan-g stuartmorgan-g deleted the flutter-master-roll-2022-12-first-failing branch December 21, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: flutter_migrate p: pigeon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants