[pigeon] Minor updates for pana #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the Flutter SDK constraint; as far as I remember and can tell from git history, we only did this to prevent pigeon from running tests on unsupported versions before the repo tooling supported minimum Dart versions. - Removes an unnecessary null check. We intentionally have that analysis option off for the repo as long as Flutter supports non-strong-mode code, but the specific check here isn't subject to client code so isn't useful to keep. Part (maybe all?) of flutter/flutter#122029
github-actions
bot
added
p: pigeon
platform-android
platform-ios
platform-macos
platform-windows
labels
|
I'm hoping that removing the Flutter constraint will fix both the platforms and docs issue. |
tarrinneal
approved these changes
Mar 6, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
- Removes the Flutter SDK constraint; as far as I remember and can tell from git history, we only did this to prevent pigeon from running tests on unsupported versions before the repo tooling supported minimum Dart versions. - Removes an unnecessary null check. We intentionally have that analysis option off for the repo as long as Flutter supports non-strong-mode code, but the specific check here isn't subject to client code so isn't useful to keep. Part (maybe all?) of flutter/flutter#122029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part (maybe all?) of flutter/flutter#122029
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).