Skip to content

Update goldens #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Update goldens #3442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9b4aab
update goldens
LongCatIsLooong Mar 11, 2023
a8b9961
add temporary migration flag
LongCatIsLooong Mar 14, 2023
e8bc959
Merge remote-tracking branch 'upstream/main' into update-goldens
LongCatIsLooong Mar 15, 2023
e145c32
Merge remote-tracking branch 'upstream/main' into update-goldens
LongCatIsLooong Mar 17, 2023
1be735c
Add missing env var
LongCatIsLooong Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions customer_testing.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ REM changing this file.

CD packages/animations
CALL flutter analyze --no-fatal-infos
set USE_FLUTTER_TEST_FONT=1
CALL flutter test

REM We don't run the tests in packages/rfw because those tests are
Expand Down
2 changes: 1 addition & 1 deletion customer_testing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ flutter analyze --no-fatal-infos
if [[ "$OSTYPE" == "linux-gnu" ]]; then
# We only run the full tests on Linux because golden files differ
# from platform to platform.
flutter test
USE_FLUTTER_TEST_FONT=1 flutter test
fi
# The next script verifies that the coverage is not regressed; it does
# not verify goldens. (It does run all the tests though, so it still
Expand Down
Binary file modified packages/rfw/test/goldens/material_test.drawer.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/rfw/test/goldens/material_test.scaffold.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion script/tool_runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ readonly TOOL_PATH="$REPO_DIR/script/tool/bin/flutter_plugin_tools.dart"
cd "$REPO_DIR"
# Run from the in-tree source.
# PACKAGE_SHARDING is (optionally) set from Cirrus. See .cirrus.yml
dart run "$TOOL_PATH" "$@" --packages-for-branch --log-timing $PACKAGE_SHARDING
USE_FLUTTER_TEST_FONT=1 dart run "$TOOL_PATH" "$@" --packages-for-branch --log-timing $PACKAGE_SHARDING