Skip to content

[ci/tool] Add external dependency validation #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 17, 2023
Merged
2 changes: 1 addition & 1 deletion .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ task:
license_script: $PLUGIN_TOOL_COMMAND license-check
# The major and minor version here should match the lowest version
# analyzed in legacy_version_analyze.
pubspec_script: ./script/tool_runner.sh pubspec-check --min-min-flutter-version=3.0.0
pubspec_script: ./script/tool_runner.sh pubspec-check --min-min-flutter-version=3.0.0 --allow-dependencies=script/configs/allowed_unpinned_deps.yaml --allow-pinned-dependencies=script/configs/allowed_pinned_deps.yaml
readme_script:
- ./script/tool_runner.sh readme-check
# Re-run with --require-excerpts, skipping packages that still need
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ dev_dependencies:
sdk: flutter
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0
video_player: ^2.0.0
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ dev_dependencies:
build_runner: ^2.1.4
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
pigeon: ^3.2.6
2 changes: 1 addition & 1 deletion packages/camera/camera_web/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mocktail: ^0.3.0
mocktail: 0.3.0
Copy link
Member

@ditman ditman Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

(My bad, this should have never happened in the first place)

2 changes: 1 addition & 1 deletion packages/file_selector/file_selector_ios/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ dev_dependencies:
build_runner: 2.1.11
flutter_test:
sdk: flutter
mockito: ^5.1.0
mockito: 5.3.2
pigeon: ^3.2.5

2 changes: 1 addition & 1 deletion packages/file_selector/file_selector_macos/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ dev_dependencies:
build_runner: ^2.3.2
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
pigeon: ^4.2.14
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ dev_dependencies:
build_runner: 2.1.11
flutter_test:
sdk: flutter
mockito: ^5.1.0
mockito: 5.3.2
pigeon: ^3.2.5
2 changes: 1 addition & 1 deletion packages/flutter_markdown/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
standard_message_codec: ^0.0.1+3
2 changes: 1 addition & 1 deletion packages/flutter_migrate/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies:

dev_dependencies:
collection: 1.16.0
file_testing: ^3.0.0
file_testing: 3.0.0
lints: ^2.0.0
test: ^1.16.0
test_api: ^0.4.13
4 changes: 2 additions & 2 deletions packages/go_router/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ environment:
flutter: ">=3.3.0"

dependencies:
adaptive_dialog: ^1.2.0
adaptive_dialog: 1.8.2
adaptive_navigation: ^0.0.4
collection: ^1.15.0
cupertino_icons: ^1.0.2
Expand All @@ -17,7 +17,7 @@ dependencies:
go_router:
path: ..
logging: ^1.0.0
provider: ^6.0.0
provider: 6.0.5
shared_preferences: ^2.0.11
url_launcher: ^6.0.7

Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
flutter:
sdk: flutter
go_router: ^6.2.0
provider: ^6.0.0
provider: 6.0.5

dev_dependencies:
build_runner: ^2.0.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
path: ../
http: ^0.13.5
js: ^0.6.4
jwt_decoder: ^2.0.1
jwt_decoder: 2.0.1

dev_dependencies:
build_runner: ^2.1.10 # To extract README excerpts only.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ dev_dependencies:
async: ^2.5.0
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ dev_dependencies:
http: ^0.13.0
integration_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dev_dependencies:
http: ^0.13.0
integration_test:
sdk: flutter
mockito: ^5.1.0
mockito: 5.3.2

# The example deliberately includes limited-use secrets.
false_secrets:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ dev_dependencies:
integration_test:
sdk: flutter
js: ^0.6.3
mockito: ^5.3.2
mockito: 5.3.2
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ dev_dependencies:
cross_file: ^0.3.1+1 # Mockito generates a direct include.
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_android/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
pigeon: ^9.1.0
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_ios/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
pigeon: ^3.0.2
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_windows/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ dev_dependencies:
build_runner: ^2.1.5
flutter_test:
sdk: flutter
mockito: ^5.0.16
mockito: 5.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ dev_dependencies:
flutter_test:
sdk: flutter
json_serializable: ^6.3.1
mockito: ^5.1.0
mockito: 5.3.2
test: ^1.16.0
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
2 changes: 1 addition & 1 deletion packages/local_auth/local_auth/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mockito: ^5.1.0
mockito: 5.3.2
plugin_platform_interface: ^2.1.2
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
2 changes: 1 addition & 1 deletion packages/metrics_center/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ dependencies:
dev_dependencies:
build_runner: ^2.1.1
fake_async: ^1.2.0
mockito: ^5.0.14
mockito: 5.3.2
test: ^1.17.11
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ dev_dependencies:
build_runner: ^2.3.2
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
path: ^1.8.0
pigeon: ^5.0.0
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dev_dependencies:
build_runner: ^2.1.10
flutter_test:
sdk: flutter
mockito: ^5.0.4
mockito: 5.3.2

flutter:
uses-material-design: true
2 changes: 1 addition & 1 deletion packages/plugin_platform_interface/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ dependencies:
meta: ^1.3.0

dev_dependencies:
mockito: ^5.0.0
mockito: 5.3.2
test: ^1.16.0
2 changes: 1 addition & 1 deletion packages/quick_actions/quick_actions/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.1
mockito: 5.3.2
2 changes: 1 addition & 1 deletion packages/rfw/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
lcov_parser: ^0.1.2
lcov_parser: 0.1.2
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0

flutter:
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0
test: ^1.16.3
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0

flutter:
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_android/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0
test: ^1.16.3
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0

flutter:
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_ios/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
plugin_platform_interface: ^2.0.0
test: ^1.16.3
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dev_dependencies:
sdk: flutter
integration_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
url_launcher_platform_interface: ^2.0.3
url_launcher_web:
path: ../
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ dev_dependencies:
sdk: flutter
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
plugin_platform_interface: ^2.1.3
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ dev_dependencies:
sdk: flutter
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
pigeon: ^9.0.4
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ dev_dependencies:
build_runner: ^2.1.8
flutter_test:
sdk: flutter
mockito: ^5.0.0
mockito: 5.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ dev_dependencies:
sdk: flutter
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ dev_dependencies:
sdk: flutter
flutter_test:
sdk: flutter
mockito: ^5.3.2
mockito: 5.3.2
pigeon: ^4.2.13
24 changes: 24 additions & 0 deletions script/configs/allowed_pinned_deps.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# The list of external dependencies that are allowed as unpinned dependencies.
# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies
#
# All entries here should have an explanation for why they are here.

# TODO(stuartmorgan): Eliminate this in favor of standardizing on
# mockito.
- mocktail

# Legacy allowances, for dependencies that predate the tooling.
# TODO(stuartmorgan): Audit these. See
# https://github.com/flutter/flutter/issues/122713
- jwt_decoder
- lcov_parser
- adaptive_dialog
- provider

## Allowed by default

# Dart-owned
- mockito

# Google-owned
- file_testing
Loading