Skip to content

[camera_platform_interface] Add NV21 as an image stream format #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/camera/camera_platform_interface/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.5.0

* Adds NV21 as an image stream format (suitable for Android).
* Aligns Dart and Flutter SDK constraints.

## 2.4.1

* Updates links for the merge of flutter/plugins into flutter/packages.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ class CameraInitializedEvent extends CameraEvent {
/// The `previewWidth` represents the width of the generated preview in pixels.
/// The `previewHeight` represents the height of the generated preview in pixels.
const CameraInitializedEvent(
int cameraId,
super.cameraId,
this.previewWidth,
this.previewHeight,
this.exposureMode,
this.exposurePointSupported,
this.focusMode,
this.focusPointSupported,
) : super(cameraId);
);

/// Converts the supplied [Map] to an instance of the [CameraInitializedEvent]
/// class.
Expand Down Expand Up @@ -135,10 +135,10 @@ class CameraResolutionChangedEvent extends CameraEvent {
/// The `captureWidth` represents the width of the resulting image in pixels.
/// The `captureHeight` represents the height of the resulting image in pixels.
const CameraResolutionChangedEvent(
int cameraId,
super.cameraId,
this.captureWidth,
this.captureHeight,
) : super(cameraId);
);

/// Converts the supplied [Map] to an instance of the
/// [CameraResolutionChangedEvent] class.
Expand Down Expand Up @@ -178,7 +178,7 @@ class CameraResolutionChangedEvent extends CameraEvent {
class CameraClosingEvent extends CameraEvent {
/// Build a CameraClosing event triggered from the camera represented by
/// `cameraId`.
const CameraClosingEvent(int cameraId) : super(cameraId);
const CameraClosingEvent(super.cameraId);

/// Converts the supplied [Map] to an instance of the [CameraClosingEvent]
/// class.
Expand Down Expand Up @@ -211,7 +211,7 @@ class CameraErrorEvent extends CameraEvent {
/// `cameraId`.
///
/// The `description` represents the error occured on the camera.
const CameraErrorEvent(int cameraId, this.description) : super(cameraId);
const CameraErrorEvent(super.cameraId, this.description);

/// Converts the supplied [Map] to an instance of the [CameraErrorEvent]
/// class.
Expand Down Expand Up @@ -248,8 +248,7 @@ class VideoRecordedEvent extends CameraEvent {
/// The `file` represents the file of the video.
/// The `maxVideoDuration` shows if a maxVideoDuration shows if a maximum
/// video duration was set.
const VideoRecordedEvent(int cameraId, this.file, this.maxVideoDuration)
: super(cameraId);
const VideoRecordedEvent(super.cameraId, this.file, this.maxVideoDuration);

/// Converts the supplied [Map] to an instance of the [VideoRecordedEvent]
/// class.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ enum ImageFormatGroup {
/// On Android, this is `android.graphics.ImageFormat.JPEG`. See
/// https://developer.android.com/reference/android/graphics/ImageFormat#JPEG
jpeg,

/// YCrCb format used for images, which uses the NV21 encoding format.
///
/// On Android, this is `android.graphics.ImageFormat.NV21`. See
/// https://developer.android.com/reference/android/graphics/ImageFormat#NV21
nv21,
}

/// Extension on [ImageFormatGroup] to stringify the enum
Expand All @@ -46,6 +52,8 @@ extension ImageFormatGroupName on ImageFormatGroup {
return 'yuv420';
case ImageFormatGroup.jpeg:
return 'jpeg';
case ImageFormatGroup.nv21:
return 'nv21';
case ImageFormatGroup.unknown:
return 'unknown';
}
Expand Down
4 changes: 2 additions & 2 deletions packages/camera/camera_platform_interface/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ repository: https://github.com/flutter/packages/tree/main/packages/camera/camera
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 2.4.1
version: 2.5.0

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: ">=2.17.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ void main() {
expect(ImageFormatGroup.bgra8888.name(), 'bgra8888');
expect(ImageFormatGroup.yuv420.name(), 'yuv420');
expect(ImageFormatGroup.jpeg.name(), 'jpeg');
expect(ImageFormatGroup.nv21.name(), 'nv21');
expect(ImageFormatGroup.unknown.name(), 'unknown');
});
});
Expand Down