Skip to content

[camera] Reland implementation of flip camera while recording. App facing changes #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 11, 2023

Conversation

BradenBagby
Copy link
Contributor

@BradenBagby BradenBagby commented Mar 20, 2023

This is the final PR for the app facing camera package for the original flip/change camera PR on the old Plugins repo here: flutter/plugins#6478

The application interface was merged here: flutter/plugins#7011
The platform packages were merged here: #3460

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a pull from main.

@stuartmorgan or @camsim99 for secondary review

@BradenBagby
Copy link
Contributor Author

Is this test an issue with this PR or is the test broken in general? flutter pub get in the camera package works fine locally for me

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Mar 27, 2023

Is this test an issue with this PR or is the test broken in general? flutter pub get in the camera package works fine locally for me

The failing bot is running with Flutter 3.0.5 (that's the CHANNEL argument in the task name); presumably you're running with something newer locally.

For some reason failing pub gets in CI hang instead of giving error output, but based on what's failing it looks like the problem is that you are requiring a version of camera_avfoundation that only supports Flutter 3.3, but since camera still says it supports 3.0 we're trying to run analysis there. You'll just need to update camera to require 3.3.

@BradenBagby
Copy link
Contributor Author

Im not sure why version going from 0.10.4 to 0.10.5 is disallowed here. I must be missing something simple

@stuartmorgan-g
Copy link
Contributor

You're going from 0.10.3+2 to 0.10.5.

@BradenBagby
Copy link
Contributor Author

This PR should be good now

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit bc6a553 into flutter:main Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…cing changes (flutter#3496)

[camera] Reland implementation of flip camera while recording. App facing changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants