-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camera] Reland implementation of flip camera while recording. App facing changes #3496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera] Reland implementation of flip camera while recording. App facing changes #3496
Conversation
…ra_android packages. Fixes a couple things from the merge I originally missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a pull from main.
@stuartmorgan or @camsim99 for secondary review
Is this test an issue with this PR or is the test broken in general? flutter pub get in the camera package works fine locally for me |
The failing bot is running with Flutter 3.0.5 (that's the CHANNEL argument in the task name); presumably you're running with something newer locally. For some reason failing |
packages/camera/camera/example/integration_test/camera_test.dart
Outdated
Show resolved
Hide resolved
Im not sure why version going from 0.10.4 to 0.10.5 is disallowed here. I must be missing something simple |
You're going from |
This PR should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…. App facing changes (flutter/packages#3496)
…cing changes (flutter#3496) [camera] Reland implementation of flip camera while recording. App facing changes
This is the final PR for the app facing camera package for the original flip/change camera PR on the old Plugins repo here: flutter/plugins#6478
The application interface was merged here: flutter/plugins#7011
The platform packages were merged here: #3460