Skip to content

[ci] Update version of Chromium in benchmarks to keep up with engine. #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 31, 2023

The oldest version of Chromium (84) we were using for benchmarking is no longer supported by the web engine, so we need to update to something newer than 87+.

This PR:

  • Keeps the former "new" version as the new "old" version of Chromium (to have some sort of "continuity" in the benchmarks)
  • Updates the "new" version to match the one used in flutter/engine.

This should allow web_benchmarks_test CHROMIUM_BUILD:XXX check to pass, and re-enable merges from master.

Closes: #3611

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@auto-submit auto-submit bot merged commit e4dabc0 into flutter:main Mar 31, 2023
@ditman ditman deleted the ci-update-chromium branch March 31, 2023 23:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…flutter#3612)

[ci] Update version of Chromium in benchmarks to keep up with engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants