-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[go_router_builder] Adds support for required $extra parameter #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Hangyujin Can you take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixed the merge conflicts with |
Thanks @Michele-x98 for the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once the ci failure are fixed
@chunhtai should be good to go |
It looks like there are still some failures |
Due to the following:
But this is a CI issue because If that's not it, mind pointing me to the issue you're seeing? Thanks |
@chunhtai Got it working! |
…er#3627) [go_router_builder] Adds support for required $extra parameter
This PR includes support for having type-safe non-nullable
$extra
parameters when working withTypedGoRoutes
. Optional$extra
is still supported so this isn't a breaking change.List which issues are fixed by this PR. You must list at least one issue.
#117261
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.