Skip to content

[tool] Add initial update-dependency command #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

Adds the basic version of update-dependency, which will serve as a general-purpose command for updating dependencies across packages.

Currently:

  • It supports on pub packages.
  • It does not do any secondary updates, such as updating generated mockito or pigeon code.

More functionality will be added in the future, but this is a minimal viable command to start from.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Adds the basic version of `update-dependency`, which will serve as a
general-purpose command for updating dependencies across packages.

Currently:
- It supports on pub packages.
- It does not do any secondary updates, such as updating generated
  `mockito` or `pigeon` code.

More functionality will be added in the future, but this is a minimal
viable command to start from.
@stuartmorgan-g
Copy link
Contributor Author

(@reidbaker FYI that the base command for updating dependencies is going in; no AGP/gradle support yet, but this is where it can be added.)

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, thanks for putting this together

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit auto-submit bot merged commit 3df3ba5 into flutter:main Apr 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 4, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[tool] Add initial `update-dependency` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants