[webview_flutter_platform_interface] Adds platform interface for onHttpError callback #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
bparrishMines
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
LGTM with a couple nits
cc @stuartmorgan or @tarrinneal for a secondary review
...webview_flutter/webview_flutter_platform_interface/lib/src/platform_navigation_delegate.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
tarrinneal
approved these changes
Apr 5, 2023
ghost
force-pushed
the
on-http-error-platform-interface
branch
from
b80521d to
7b41e5b
Compare
...es/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_response_error.dart
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
on-http-error-platform-interface
branch
2 times, most recently
from
03e1463 to
9024500
Compare
|
This needs a version bump; once that's done it should be good to land. |
ghost
force-pushed
the
on-http-error-platform-interface
branch
from
9024500 to
7f692ff
Compare
ghost
force-pushed
the
on-http-error-platform-interface
branch
from
7f692ff to
00e5f21
Compare
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2023
…for onHttpError callback (flutter/packages#3645)
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…tpError callback (flutter#3645) [webview_flutter_platform_interface] Adds platform interface for onHttpError callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #3278.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.